Changeset 240270 in webkit


Ignore:
Timestamp:
Jan 22, 2019 11:54:05 AM (5 years ago)
Author:
Devin Rousso
Message:

Web Inspector: Audit: use plural strings for Passed, Failed, and Unsupported
https://bugs.webkit.org/show_bug.cgi?id=193675
<rdar://problem/46628680>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/AuditTestGroupContentView.js:

(WI.AuditTestGroupContentView.prototype.layout):

  • Localizations/en.lproj/localizedStrings.js:
Location:
trunk/Source/WebInspectorUI
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r240176 r240270  
     12019-01-22  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: Audit: use plural strings for Passed, Failed, and Unsupported
     4        https://bugs.webkit.org/show_bug.cgi?id=193675
     5        <rdar://problem/46628680>
     6
     7        Reviewed by Joseph Pecoraro.
     8
     9        * UserInterface/Views/AuditTestGroupContentView.js:
     10        (WI.AuditTestGroupContentView.prototype.layout):
     11
     12        * Localizations/en.lproj/localizedStrings.js:
     13
    1142019-01-18  Jer Noble  <jer.noble@apple.com>
    215
  • trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

    r239858 r240270  
    2626localizedStrings["%d Errors"] = "%d Errors";
    2727localizedStrings["%d Errors, %d Warnings"] = "%d Errors, %d Warnings";
    28 localizedStrings["%d Failed"] = "%d Failed";
     28localizedStrings["%d Failed (plural)"] = "%d Failed";
     29localizedStrings["%d Failed (singular)"] = "%d Failed";
    2930localizedStrings["%d Frame"] = "%d Frame";
    3031localizedStrings["%d Frames"] = "%d Frames";
    3132localizedStrings["%d More\u2026"] = "%d More\u2026";
    32 localizedStrings["%d Passed"] = "%d Passed";
     33localizedStrings["%d Passed (plural)"] = "%d Passed";
     34localizedStrings["%d Passed (singular)"] = "%d Passed";
    3335localizedStrings["%d Threads"] = "%d Threads";
    34 localizedStrings["%d Unsupported"] = "%d Unsupported";
     36localizedStrings["%d Unsupported (plural)"] = "%d Unsupported";
     37localizedStrings["%d Unsupported (singular)"] = "%d Unsupported";
    3538localizedStrings["%d Warning"] = "%d Warning";
    3639localizedStrings["%d Warnings"] = "%d Warnings";
  • trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js

    r239858 r240270  
    123123            };
    124124
    125             addScopeBarItem(WI.AuditTestCaseResult.Level.Pass, WI.UIString("%d Passed"));
     125            addScopeBarItem(WI.AuditTestCaseResult.Level.Pass, WI.UIString("%d Passed", "%d Passed (singular)"), WI.UIString("%d Passed", "%d Passed (plural)"));
    126126            addScopeBarItem(WI.AuditTestCaseResult.Level.Warn, WI.UIString("%d Warning"), WI.UIString("%d Warnings"));
    127             addScopeBarItem(WI.AuditTestCaseResult.Level.Fail, WI.UIString("%d Failed"));
     127            addScopeBarItem(WI.AuditTestCaseResult.Level.Fail, WI.UIString("%d Failed", "%d Failed (singular)"), WI.UIString("%d Failed", "%d Failed (plural)"));
    128128            addScopeBarItem(WI.AuditTestCaseResult.Level.Error, WI.UIString("%d Error"), WI.UIString("%d Errors"));
    129             addScopeBarItem(WI.AuditTestCaseResult.Level.Unsupported, WI.UIString("%d Unsupported"));
     129            addScopeBarItem(WI.AuditTestCaseResult.Level.Unsupported, WI.UIString("%d Unsupported", "%d Unsupported (singular)"), WI.UIString("%d Unsupported", "%d Unsupported (plural)"));
    130130
    131131            this._levelScopeBar = new WI.ScopeBar(null, scopeBarItems);
Note: See TracChangeset for help on using the changeset viewer.