Changeset 240305 in webkit

Timestamp:

Jan 22, 2019 4:13:41 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Dynamic changes in the style attributes of an SVGElement do no affect the <use> instances
​https://bugs.webkit.org/show_bug.cgi?id=193647

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-01-22
Reviewed by Simon Fraser.

Source/WebCore:

Changing a style attribute of an SVGELement needs to call invalidateInstances().

Tests: svg/custom/svg-use-style-dynamic-change-invalidate.svg

• svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged):

LayoutTests:

• svg/custom/svg-use-style-dynamic-change-invalidate-expected.svg: Added.
• svg/custom/svg-use-style-dynamic-change-invalidate.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/custom/svg-use-style-dynamic-change-invalidate-expected.svg (added)
• LayoutTests/svg/custom/svg-use-style-dynamic-change-invalidate.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-01-22  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        Dynamic changes in the style attributes of an SVGElement do no affect the <use> instances
+        https://bugs.webkit.org/show_bug.cgi?id=193647
+
+        Reviewed by Simon Fraser.
+
+        * svg/custom/svg-use-style-dynamic-change-invalidate-expected.svg: Added.
+        * svg/custom/svg-use-style-dynamic-change-invalidate.svg: Added.
+
 2019-01-22  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-01-22  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        Dynamic changes in the style attributes of an SVGElement do no affect the <use> instances
+        https://bugs.webkit.org/show_bug.cgi?id=193647
+
+        Reviewed by Simon Fraser.
+
+        Changing a style attribute of an SVGELement needs to call invalidateInstances().
+
+        Tests: svg/custom/svg-use-style-dynamic-change-invalidate.svg
+
+        * svg/SVGElement.cpp:
+        (WebCore::SVGElement::attributeChanged):
+
 2019-01-22  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/svg/SVGElement.cpp

@@ -687 +687 @@
 
     // Changes to the style attribute are processed lazily (see Element::getAttribute() and related methods),
-    // so we don't want changes to the style attribute to result in extra work here.
-    if (name != HTMLNames::styleAttr)
+    // so we don't want changes to the style attribute to result in extra work here except invalidateInstances().
+    if (name == HTMLNames::styleAttr)
+        invalidateInstances();
+    else
         svgAttributeChanged(name);
 }