Changeset 240332 in webkit


Ignore:
Timestamp:
Jan 23, 2019 3:58:15 AM (5 years ago)
Author:
ddkilzer@apple.com
Message:

Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h}
<https://webkit.org/b/193694>
<rdar://problem/47464025>

Reviewed by Tim Horton.

Source/WebCore/PAL:

  • pal/cf/CoreMediaSoftLink.cpp:
  • Export kCMTimeZero soft-link.
  • pal/cf/CoreMediaSoftLink.h:
  • Update kCMTimeZero macro to use PAL namespace for use in WebKit.framework.

Source/WebKit:

  • Shared/ios/WebIconUtilities.mm:
  • Switch to using CoreMediaSoftLink.{h,mm} in PAL.

Source/WTF:

  • wtf/win/SoftLinking.h:

(SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT):

  • Implement for Windows.

(SOFT_LINK_CONSTANT_FOR_SOURCE):

  • Define using SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT().
Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WTF/ChangeLog

    r240255 r240332  
     12019-01-23  David Kilzer  <ddkilzer@apple.com>
     2
     3        Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h}
     4        <https://webkit.org/b/193694>
     5        <rdar://problem/47464025>
     6
     7        Reviewed by Tim Horton.
     8
     9        * wtf/win/SoftLinking.h:
     10        (SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT):
     11        - Implement for Windows.
     12        (SOFT_LINK_CONSTANT_FOR_SOURCE):
     13        - Define using SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT().
     14
    1152019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
    216
  • trunk/Source/WTF/wtf/win/SoftLinking.h

    r238541 r240332  
    193193    }
    194194
    195 #define SOFT_LINK_CONSTANT_FOR_SOURCE(functionNamespace, framework, variableName, variableType) \
     195#define SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT(functionNamespace, framework, variableName, variableType, export) \
    196196    namespace functionNamespace { \
    197197    static void init##framework##variableName(void* context) { \
     
    200200        *static_cast<variableType*>(context) = *ptr; \
    201201    } \
    202     variableType get_##framework##_##variableName(); \
     202    export variableType get_##framework##_##variableName(); \
    203203    variableType get_##framework##_##variableName() \
    204204    { \
     
    209209    } \
    210210    }
     211
     212#define SOFT_LINK_CONSTANT_FOR_SOURCE(functionNamespace, framework, variableName, variableType) \
     213    SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT(functionNamespace, framework, variableName, variableType, )
    211214
    212215#define SOFT_LINK_CONSTANT_MAY_FAIL_FOR_HEADER(functionNamespace, framework, variableName, variableType) \
  • trunk/Source/WebCore/PAL/ChangeLog

    r240272 r240332  
     12019-01-23  David Kilzer  <ddkilzer@apple.com>
     2
     3        Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h}
     4        <https://webkit.org/b/193694>
     5        <rdar://problem/47464025>
     6
     7        Reviewed by Tim Horton.
     8
     9        * pal/cf/CoreMediaSoftLink.cpp:
     10        - Export kCMTimeZero soft-link.
     11        * pal/cf/CoreMediaSoftLink.h:
     12        - Update kCMTimeZero macro to use PAL namespace for use in
     13          WebKit.framework.
     14
    1152019-01-22  David Kilzer  <ddkilzer@apple.com>
    216
  • trunk/Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp

    r239636 r240332  
    8484SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, CoreMedia, kCMTextVerticalLayout_RightToLeft, CFStringRef)
    8585SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, CoreMedia, kCMTimeInvalid, CMTime)
    86 SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, CoreMedia, kCMTimeZero, CMTime)
     86SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT(PAL, CoreMedia, kCMTimeZero, CMTime, PAL_EXPORT)
    8787SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, CoreMedia, kCMTimePositiveInfinity, CMTime)
    8888SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, CoreMedia, kCMTimeRangeInvalid, CMTimeRange);
  • trunk/Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h

    r239636 r240332  
    126126#define kCMTimeInvalid get_CoreMedia_kCMTimeInvalid()
    127127SOFT_LINK_CONSTANT_FOR_HEADER(PAL, CoreMedia, kCMTimeZero, CMTime)
    128 #define kCMTimeZero get_CoreMedia_kCMTimeZero()
     128#define kCMTimeZero PAL::get_CoreMedia_kCMTimeZero()
    129129SOFT_LINK_CONSTANT_FOR_HEADER(PAL, CoreMedia, kCMTimePositiveInfinity, CMTime)
    130130#define kCMTimePositiveInfinity get_CoreMedia_kCMTimePositiveInfinity()
  • trunk/Source/WebKit/ChangeLog

    r240325 r240332  
     12019-01-23  David Kilzer  <ddkilzer@apple.com>
     2
     3        Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h}
     4        <https://webkit.org/b/193694>
     5        <rdar://problem/47464025>
     6
     7        Reviewed by Tim Horton.
     8
     9        * Shared/ios/WebIconUtilities.mm:
     10        - Switch to using CoreMediaSoftLink.{h,mm} in PAL.
     11
    1122019-01-22  Chris Dumez  <cdumez@apple.com>
    213
  • trunk/Source/WebKit/Shared/ios/WebIconUtilities.mm

    r237266 r240332  
    3535#import <ImageIO/ImageIO.h>
    3636#import <MobileCoreServices/MobileCoreServices.h>
     37#import <pal/cf/CoreMediaSoftLink.h>
    3738#import <wtf/MathExtras.h>
    3839#import <wtf/RetainPtr.h>
     
    4243SOFT_LINK_CLASS(AVFoundation, AVAssetImageGenerator);
    4344SOFT_LINK_CLASS(AVFoundation, AVURLAsset);
    44 
    45 SOFT_LINK_FRAMEWORK(CoreMedia);
    46 SOFT_LINK_CONSTANT(CoreMedia, kCMTimeZero, CMTime);
    47 
    48 #define kCMTimeZero getkCMTimeZero()
    4945
    5046namespace WebKit {
Note: See TracChangeset for help on using the changeset viewer.