Changeset 240352 in webkit

Timestamp:

Jan 23, 2019 12:09:54 PM (5 years ago)

Author:

Wenson Hsieh

Message:

[iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
​https://bugs.webkit.org/show_bug.cgi?id=193182
<rdar://problem/47452154>

Reviewed by Tim Horton.

Source/WebKit:

Fix an existing bug where blurring an element doesn't always un-suppress text interactions.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _elementDidBlur]):

Tools:

This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.

To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
preventing later tests from recognizing gestures.

• WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues):

Cancel all touches in the UIApplication when resetting to a consistent state between tests.

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/ios/TestControllerIOS.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
+        https://bugs.webkit.org/show_bug.cgi?id=193182
+        <rdar://problem/47452154>
+
+        Reviewed by Tim Horton.
+
+        Fix an existing bug where blurring an element doesn't always un-suppress text interactions.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView _elementDidBlur]):
+
 2019-01-23  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -4661 +4661 @@
     if (!_isChangingFocus) {
         [self _stopSuppressingSelectionAssistantForReason:WebKit::FocusedElementIsTransparentOrFullyClipped];
+        [self _stopSuppressingSelectionAssistantForReason:WebKit::FocusedElementIsTooSmall];
         _didAccessoryTabInitiateFocus = NO;
     }

trunk/Tools/ChangeLog

@@ +1 @@
+2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
+        https://bugs.webkit.org/show_bug.cgi?id=193182
+        <rdar://problem/47452154>
+
+        Reviewed by Tim Horton.
+
+        This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
+        long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
+        recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
+
+        To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
+        preventing later tests from recognizing gestures.
+
+        * WebKitTestRunner/ios/TestControllerIOS.mm:
+        (WTR::TestController::platformResetStateToConsistentValues):
+
+        Cancel all touches in the UIApplication when resetting to a consistent state between tests.
+
 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm

@@ -116 +116 @@
     cocoaResetStateToConsistentValues(options);
 
+    [[UIApplication sharedApplication] _cancelAllTouches];
     [[UIDevice currentDevice] setOrientation:UIDeviceOrientationPortrait animated:NO];