Changeset 240444 in webkit
- Timestamp:
- Jan 24, 2019 11:17:09 AM (5 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 18 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r240362 r240444 1 2019-01-24 John Wilander <wilander@apple.com> 2 3 Add Ad Click Attribution as an internal/experimental feature 4 https://bugs.webkit.org/show_bug.cgi?id=193685 5 <rdar://problem/47450399> 6 7 Reviewed by Brent Fulgham. 8 9 * http/tests/adClickAttribution/anchor-tag-attributes-reflect-expected.txt: Added. 10 * http/tests/adClickAttribution/anchor-tag-attributes-reflect.html: Added. 11 * platform/win/TestExpectations: 12 Skipped on Windows for now. 13 1 14 2019-01-23 Oriol Brufau <obrufau@igalia.com> 2 15 -
trunk/LayoutTests/platform/win/TestExpectations
r240205 r240444 111 111 webkit.org/b/173281 editing/selection/selection-across-shadow-boundaries-readonly-3.html [ Skip ] 112 112 webkit.org/b/173281 editing/selection/selection-across-shadow-boundaries-user-select-all-1.html [ Skip ] 113 webkit.org/b/193748 http/tests/adClickAttribution [ Skip ] 113 114 114 115 # TODO HW filters not yet supported on Windows -
trunk/Source/WebCore/ChangeLog
r240441 r240444 1 2019-01-24 John Wilander <wilander@apple.com> 2 3 Add Ad Click Attribution as an internal/experimental feature 4 https://bugs.webkit.org/show_bug.cgi?id=193685 5 <rdar://problem/47450399> 6 7 Reviewed by Brent Fulgham. 8 9 Test: http/tests/adClickAttribution/anchor-tag-attributes-reflect.html 10 11 * html/HTMLAnchorElement.h: 12 * html/HTMLAnchorElement.idl: 13 * html/HTMLAttributeNames.in: 14 Addeed two new experimental attributes: 15 - adcampaignid: Ad campaign ID. 16 - addestination: Ad link destination site. 17 * page/RuntimeEnabledFeatures.h: 18 (WebCore::RuntimeEnabledFeatures::adClickAttributionEnabled const): 19 (WebCore::RuntimeEnabledFeatures::setAdClickAttributionEnabled): 20 * page/Settings.yaml: 21 1 22 2019-01-24 Youenn Fablet <youenn@apple.com> 2 23 -
trunk/Source/WebCore/html/HTMLAnchorElement.idl
r238748 r240444 20 20 21 21 interface HTMLAnchorElement : HTMLElement { 22 [CEReactions=NotNeeded, EnabledAtRuntime=AdClickAttribution, Reflect] attribute DOMString adcampaignid; 23 [CEReactions=NotNeeded, EnabledAtRuntime=AdClickAttribution, Reflect] attribute DOMString addestination; 22 24 [CEReactions=NotNeeded, Reflect] attribute DOMString charset; 23 25 [CEReactions=NotNeeded, Reflect] attribute DOMString coords; -
trunk/Source/WebCore/html/HTMLAttributeNames.in
r238108 r240444 67 67 as 68 68 async 69 adcampaignid 70 addestination 69 71 autocomplete 70 72 autofocus -
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
r240251 r240444 341 341 void setCSSLogicalEnabled(bool isEnabled) { m_CSSLogicalEnabled = isEnabled; } 342 342 bool cssLogicalEnabled() const { return m_CSSLogicalEnabled; } 343 344 bool adClickAttributionEnabled() const { return m_adClickAttributionEnabled; } 345 void setAdClickAttributionEnabled(bool isEnabled) { m_adClickAttributionEnabled = isEnabled; } 343 346 344 347 WEBCORE_EXPORT static RuntimeEnabledFeatures& sharedFeatures(); … … 517 520 bool m_CSSLogicalEnabled { false }; 518 521 522 bool m_adClickAttributionEnabled { false }; 523 519 524 friend class WTF::NeverDestroyed<RuntimeEnabledFeatures>; 520 525 }; -
trunk/Source/WebCore/page/Settings.yaml
r240129 r240444 789 789 editableImagesEnabled: 790 790 initial: false 791 792 adClickAttributionEnabled: 793 initial: false -
trunk/Source/WebKit/ChangeLog
r240443 r240444 1 2019-01-24 John Wilander <wilander@apple.com> 2 3 Add Ad Click Attribution as an internal/experimental feature 4 https://bugs.webkit.org/show_bug.cgi?id=193685 5 <rdar://problem/47450399> 6 7 Reviewed by Brent Fulgham. 8 9 * Shared/WebPreferences.yaml: 10 Added AdClickAttributionEnabled as a runtime enabled feature, off by default. 11 1 12 2019-01-24 Antti Koivisto <antti@apple.com> 2 13 -
trunk/Source/WebKit/Shared/WebPreferences.yaml
r240251 r240444 1544 1544 webcoreBinding: RuntimeEnabledFeatures 1545 1545 category: internal 1546 1547 AdClickAttributionEnabled: 1548 type: bool 1549 defaultValue: false 1550 humanReadableName: "Ad Click Attribution" 1551 humanReadableDescription: "Enable Ad Click Attribution for Cross-Site Link Navigations" 1552 webcoreBinding: RuntimeEnabledFeatures 1553 category: internal -
trunk/Source/WebKitLegacy/mac/ChangeLog
r240437 r240444 1 2019-01-24 John Wilander <wilander@apple.com> 2 3 Add Ad Click Attribution as an internal/experimental feature 4 https://bugs.webkit.org/show_bug.cgi?id=193685 5 <rdar://problem/47450399> 6 7 Reviewed by Brent Fulgham. 8 9 * WebView/WebPreferenceKeysPrivate.h: 10 * WebView/WebPreferences.mm: 11 (+[WebPreferences initialize]): 12 (-[WebPreferences adClickAttributionEnabled]): 13 (-[WebPreferences setAdClickAttributionEnabled:]): 14 Added support for experimental ad click attribution. 15 * WebView/WebPreferencesPrivate.h: 16 * WebView/WebView.mm: 17 (-[WebView _preferencesChanged:]): 18 1 19 2019-01-24 Ross Kirsling <ross.kirsling@sony.com> 2 20 -
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
r240251 r240444 265 265 #define WebKitSelectionAcrossShadowBoundariesEnabledPreferenceKey @"WebKitSelectionAcrossShadowBoundariesEnabled" 266 266 #define WebKitCSSLogicalEnabledPreferenceKey @"WebKitCSSLogicalEnabled" 267 #define WebKitAdClickAttributionEnabledPreferenceKey @"WebKitAdClickAttributionEnabled" -
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
r240292 r240444 671 671 [NSNumber numberWithBool:YES], WebKitSelectionAcrossShadowBoundariesEnabledPreferenceKey, 672 672 [NSNumber numberWithBool:NO], WebKitCSSLogicalEnabledPreferenceKey, 673 [NSNumber numberWithBool:NO], WebKitAdClickAttributionEnabledPreferenceKey, 673 674 #if ENABLE(INTERSECTION_OBSERVER) 674 675 @NO, WebKitIntersectionObserverEnabledPreferenceKey, … … 3391 3392 } 3392 3393 3394 - (BOOL)adClickAttributionEnabled 3395 { 3396 return [self _boolValueForKey:WebKitAdClickAttributionEnabledPreferenceKey]; 3397 } 3398 3399 - (void)setAdClickAttributionEnabled:(BOOL)flag 3400 { 3401 [self _setBoolValue:flag forKey:WebKitAdClickAttributionEnabledPreferenceKey]; 3402 } 3403 3393 3404 @end 3394 3405 -
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
r240251 r240444 585 585 - (void)setCSSLogicalEnabled:(BOOL)flag; 586 586 - (BOOL)cssLogicalEnabled; 587 588 - (BOOL)adClickAttributionEnabled; 589 - (void)setAdClickAttributionEnabled:(BOOL)flag; 587 590 588 591 @property (nonatomic) BOOL visualViewportEnabled; -
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
r240437 r240444 3080 3080 RuntimeEnabledFeatures::sharedFeatures().setCSSLogicalEnabled([preferences cssLogicalEnabled]); 3081 3081 3082 RuntimeEnabledFeatures::sharedFeatures().setAdClickAttributionEnabled([preferences adClickAttributionEnabled]); 3083 3082 3084 settings.setHiddenPageDOMTimerThrottlingEnabled([preferences hiddenPageDOMTimerThrottlingEnabled]); 3083 3085 -
trunk/Tools/ChangeLog
r240443 r240444 1 2019-01-24 John Wilander <wilander@apple.com> 2 3 Add Ad Click Attribution as an internal/experimental feature 4 https://bugs.webkit.org/show_bug.cgi?id=193685 5 <rdar://problem/47450399> 6 7 Reviewed by Brent Fulgham. 8 9 Added test option adClickAttributionEnabled. 10 11 * DumpRenderTree/TestOptions.cpp: 12 (TestOptions::TestOptions): 13 * DumpRenderTree/TestOptions.h: 14 * DumpRenderTree/mac/DumpRenderTree.mm: 15 (setWebPreferencesForTestOptions): 16 1 17 2019-01-24 Antti Koivisto <antti@apple.com> 2 18 -
trunk/Tools/DumpRenderTree/TestOptions.cpp
r240251 r240444 110 110 else if (key == "internal:CSSLogicalEnabled") 111 111 enableCSSLogical = parseBooleanTestHeaderValue(value); 112 else if (key == "internal:AdClickAttributionEnabled") 113 adClickAttributionEnabled = parseBooleanTestHeaderValue(value); 112 114 pairStart = pairEnd + 1; 113 115 } -
trunk/Tools/DumpRenderTree/TestOptions.h
r240251 r240444 46 46 bool enableWebGPU { false }; 47 47 bool enableCSSLogical { false }; 48 bool adClickAttributionEnabled { false }; 48 49 std::string jscOptions; 49 50 -
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
r240358 r240444 1012 1012 preferences.webGPUEnabled = options.enableWebGPU; 1013 1013 preferences.CSSLogicalEnabled = options.enableCSSLogical; 1014 preferences.adClickAttributionEnabled = options.adClickAttributionEnabled; 1014 1015 } 1015 1016
Note: See TracChangeset
for help on using the changeset viewer.