Changeset 240448 in webkit

Timestamp:

Jan 24, 2019 2:07:33 PM (5 years ago)

Author:

sbarati@apple.com

Message:

Update ARM64EHash
​https://bugs.webkit.org/show_bug.cgi?id=193776
<rdar://problem/47526457>

Reviewed by Mark Lam.

See radar for details.

• assembler/AssemblerBuffer.h:

(JSC::ARM64EHash::update):
(JSC::ARM64EHash::finalHash const):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/AssemblerBuffer.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-01-24  Saam Barati  <sbarati@apple.com>
+
+        Update ARM64EHash
+        https://bugs.webkit.org/show_bug.cgi?id=193776
+        <rdar://problem/47526457>
+
+        Reviewed by Mark Lam.
+
+        See radar for details.
+
+        * assembler/AssemblerBuffer.h:
+        (JSC::ARM64EHash::update):
+        (JSC::ARM64EHash::finalHash const):
+
 2019-01-24  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/assembler/AssemblerBuffer.h

@@ -156 +156 @@
             uint64_t a = static_cast<uint32_t>(tagInt(input, static_cast<PtrTag>(0)) >> 39);
             uint64_t b = tagInt(input, static_cast<PtrTag>(0xb7e151628aed2a6a)) >> 23;
-            m_hash = a | b;
+            m_hash = a ^ b;
         }
         uint32_t finalHash() const
@@ -163 +163 @@
             uint64_t a = static_cast<uint32_t>(tagInt(hash, static_cast<PtrTag>(0xbf7158809cf4f3c7)) >> 39);
             uint64_t b = tagInt(hash, static_cast<PtrTag>(0x62e7160f38b4da56)) >> 23;
-            return static_cast<uint32_t>(a | b);
+            return static_cast<uint32_t>(a ^ b);
         }
     private: