Changeset 240451 in webkit


Ignore:
Timestamp:
Jan 24, 2019 3:15:56 PM (5 years ago)
Author:
jer.noble@apple.com
Message:

Fix leak of AVSampleBufferRenderSynchronizer boundaryObserver object.
https://bugs.webkit.org/show_bug.cgi?id=193778

Reviewed by Jon Lee.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::performTaskAtMediaTime):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r240450 r240451  
     12019-01-24  Jer Noble  <jer.noble@apple.com>
     2
     3        Fix leak of AVSampleBufferRenderSynchronizer boundaryObserver object.
     4        https://bugs.webkit.org/show_bug.cgi?id=193778
     5
     6        Reviewed by Jon Lee.
     7
     8        * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
     9        (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::performTaskAtMediaTime):
     10
    1112019-01-24  Zalan Bujtas  <zalan@apple.com>
    212
  • trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm

    r240437 r240451  
    11041104    __block WTF::Function<void()> taskIn = WTFMove(task);
    11051105
    1106     [m_synchronizer addBoundaryTimeObserverForTimes:@[[NSValue valueWithCMTime:toCMTime(time)]] queue:dispatch_get_main_queue() usingBlock:^{
     1106    if (m_performTaskObserver)
     1107        [m_synchronizer removeTimeObserver:m_performTaskObserver.get()];
     1108
     1109    m_performTaskObserver = [m_synchronizer addBoundaryTimeObserverForTimes:@[[NSValue valueWithCMTime:toCMTime(time)]] queue:dispatch_get_main_queue() usingBlock:^{
    11071110        taskIn();
    11081111    }];
Note: See TracChangeset for help on using the changeset viewer.