Changeset 240497 in webkit
- Timestamp:
- Jan 25, 2019 12:45:04 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 2 deleted
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r240492 r240497 1 2019-01-25 Ryosuke Niwa <rniwa@webkit.org> 2 3 iOS: inputmode="none" disables hardware keyboard's globe key 4 https://bugs.webkit.org/show_bug.cgi?id=193811 5 <rdar://problem/47406553> 6 7 Reviewed by Wenson Hsieh. 8 9 Updated and renamed the test expecting the keyboard to update upon inputmode content attribute changed 10 to use inputmode="decimal" instead of inputmode="none", and updated another test to expect inputmode="none" 11 has no effect instead of hiding the keyboard. 12 13 * fast/forms/ios/inputmode-change-update-keyboard-expected.txt: Renamed from inputmode-none-removed-expected.txt. 14 * fast/forms/ios/inputmode-change-update-keyboard.html: Renamed from inputmode-none-removed.html. 15 * fast/forms/ios/inputmode-none-expected.txt: 16 * fast/forms/ios/inputmode-none.html: 17 1 18 2019-01-25 Jonathan Bedard <jbedard@apple.com> 2 19 -
trunk/LayoutTests/fast/forms/ios/inputmode-none-expected.txt
r235426 r240497 6 6 7 7 ACTIVATE input with inputmode=text 8 PASS systemKeyboardRect.height > 0 is true8 PASS textKeyboardHeight = systemKeyboardRect.height; systemKeyboardRect.height > 0 is true 9 9 PASS inputWithSystemKeyboard.value is "Text" 10 10 11 11 ACTIVATE input with inputmode=none 12 PASS systemKeyboardRect.height === 0 is true12 PASS systemKeyboardRect.height is textKeyboardHeight 13 13 14 14 TEST enter text in input with inputmode=none -
trunk/LayoutTests/fast/forms/ios/inputmode-none.html
r235426 r240497 21 21 await UIHelper.activateFormControl(inputWithSystemKeyboard); 22 22 systemKeyboardRect = await UIHelper.inputViewBounds(); 23 shouldBe(' systemKeyboardRect.height > 0', 'true');23 shouldBe('textKeyboardHeight = systemKeyboardRect.height; systemKeyboardRect.height > 0', 'true'); 24 24 await UIHelper.enterText("Text"); 25 25 shouldBe('inputWithSystemKeyboard.value', '"Text"'); … … 28 28 await UIHelper.activateFormControl(inputWithoutSystemKeyboard); 29 29 systemKeyboardRect = await UIHelper.inputViewBounds(); 30 shouldBe('systemKeyboardRect.height === 0', 'true');30 shouldBe('systemKeyboardRect.height', 'textKeyboardHeight'); 31 31 32 32 debug('\nTEST enter text in input with inputmode=none'); -
trunk/Source/WebKit/ChangeLog
r240494 r240497 1 2019-01-25 Ryosuke Niwa <rniwa@webkit.org> 2 3 iOS: inputmode="none" disables hardware keyboard's globe key 4 https://bugs.webkit.org/show_bug.cgi?id=193811 5 <rdar://problem/47406553> 6 7 Reviewed by Wenson Hsieh. 8 9 Removed the support for inputmode="none" for now since we need a new SPI from UIKit 10 to properly implement this feature some time in the future. 11 12 * UIProcess/ios/WKContentViewInteraction.mm: 13 (-[WKContentView _zoomToRevealFocusedElement]): 14 (-[WKContentView inputView]): 15 (-[WKContentView requiresAccessoryView]): 16 (-[WKContentView textInputTraits]): 17 1 18 2019-01-25 David Kilzer <ddkilzer@apple.com> 2 19 -
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
r240491 r240497 1421 1421 maximumScale:_focusedElementInformation.maximumScaleFactorIgnoringAlwaysScalable 1422 1422 allowScaling:_focusedElementInformation.allowsUserScalingIgnoringAlwaysScalable && !currentUserInterfaceIdiomIsPad() 1423 forceScroll: (_focusedElementInformation.inputMode == WebCore::InputMode::None) ? !currentUserInterfaceIdiomIsPad() :[self requiresAccessoryView]];1423 forceScroll:[self requiresAccessoryView]]; 1424 1424 } 1425 1425 … … 1428 1428 if (!hasFocusedElement(_focusedElementInformation)) 1429 1429 return nil; 1430 1431 if (_focusedElementInformation.inputMode == WebCore::InputMode::None)1432 return [[UIView new] autorelease];1433 1430 1434 1431 if (!_inputPeripheral) { … … 2208 2205 if ([_formInputSession customInputAccessoryView]) 2209 2206 return YES; 2210 2211 if (_focusedElementInformation.inputMode == WebCore::InputMode::None)2212 return NO;2213 2207 2214 2208 switch (_focusedElementInformation.elementType) { … … 3813 3807 3814 3808 switch (_focusedElementInformation.inputMode) { 3809 case WebCore::InputMode::None: 3815 3810 case WebCore::InputMode::Unspecified: 3816 3811 switch (_focusedElementInformation.elementType) { … … 3849 3844 [_traits setKeyboardType:UIKeyboardTypeDefault]; 3850 3845 } 3851 break;3852 case WebCore::InputMode::None:3853 3846 break; 3854 3847 case WebCore::InputMode::Text:
Note: See TracChangeset
for help on using the changeset viewer.