Changeset 240502 in webkit

Timestamp:

Jan 25, 2019 1:49:03 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Audit: remove experimental setting
​https://bugs.webkit.org/show_bug.cgi?id=193743
<rdar://problem/28234022>

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Setting.js:

(WI.Setting):
(WI.Setting.localStorageKey): Added.
(WI.Setting.migrateValue):
Drive-by: add the localStorage key prefix to the key passed into WI.Setting.migrateValue.

• UserInterface/Base/Main.js:

(WI.loaded):

• UserInterface/Views/AuditTabContentView.js:

(WI.AuditTabContentView.isTabAllowed):

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

• Localizations/en.lproj/localizedStrings.js:

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (2 diffs)
• UserInterface/Base/Main.js (modified) (1 diff)
• UserInterface/Views/AuditTabContentView.js (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-01-25  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Audit: remove experimental setting
+        https://bugs.webkit.org/show_bug.cgi?id=193743
+        <rdar://problem/28234022>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Base/Setting.js:
+        (WI.Setting):
+        (WI.Setting.localStorageKey): Added.
+        (WI.Setting.migrateValue):
+        Drive-by: add the localStorage key prefix to the key passed into `WI.Setting.migrateValue`.
+
+        * UserInterface/Base/Main.js:
+        (WI.loaded):
+
+        * UserInterface/Views/AuditTabContentView.js:
+        (WI.AuditTabContentView.isTabAllowed):
+
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
+        * Localizations/en.lproj/localizedStrings.js:
+
 2019-01-25  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -134 +134 @@
 localizedStrings["Audit Error: %s"] = "Audit Error: %s";
 localizedStrings["Audit Warning: %s"] = "Audit Warning: %s";
-localizedStrings["Audit:"] = "Audit:";
 localizedStrings["Audits"] = "Audits";
 localizedStrings["Author Stylesheet"] = "Author Stylesheet";
@@ -362 +361 @@
 localizedStrings["Element overlaps other compositing element"] = "Element overlaps other compositing element";
 localizedStrings["Elements"] = "Elements";
-localizedStrings["Enable Audit Tab"] = "Enable Audit Tab";
 localizedStrings["Enable Breakpoint"] = "Enable Breakpoint";
 localizedStrings["Enable Breakpoints"] = "Enable Breakpoints";

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -149 +149 @@
         WI.StorageTabContentView.Type,
         WI.CanvasTabContentView.Type,
+        WI.AuditTabContentView.Type,
         WI.ConsoleTabContentView.Type,
     ]);

trunk/Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js

@@ -50 +50 @@
     static isTabAllowed()
     {
-        return !!window.RuntimeAgent && WI.settings.experimentalEnableAuditTab.value;
+        return WI.sharedApp.debuggableType === WI.DebuggableType.Web;
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

@@ -265 +265 @@
         }
 
-        experimentalSettingsView.addSetting(WI.UIString("Audit:"), WI.settings.experimentalEnableAuditTab, WI.UIString("Enable Audit Tab"));
-        experimentalSettingsView.addSeparator();
-
         experimentalSettingsView.addSetting(WI.UIString("User Interface:"), WI.settings.experimentalEnableNewTabBar, WI.UIString("Enable New Tab Bar"));
         experimentalSettingsView.addSeparator();
@@ -278 +275 @@
             if (!initialValues.get(WI.settings.experimentalEnableLayersTab) && window.LayerTreeAgent && WI.settings.experimentalEnableLayersTab.value)
                 newTabs.push(WI.LayersTabContentView.Type);
-            if (!initialValues.get(WI.settings.experimentalEnableAuditTab) && WI.settings.experimentalEnableAuditTab.value)
-                newTabs.push(WI.AuditTabContentView.Type);
             WI._openTabsSetting.value = newTabs;
 
@@ -297 +292 @@
         listenForChange(WI.settings.experimentalEnableComputedStyleCascades);
         listenForChange(WI.settings.experimentalEnableLayersTab);
-        listenForChange(WI.settings.experimentalEnableAuditTab);
         listenForChange(WI.settings.experimentalEnableNewTabBar);