Changeset 240531 in webkit

Timestamp:

Jan 25, 2019 4:44:42 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

Find-in-page on nyt.com scrolls around without touching the screen when find holes are visible
​https://bugs.webkit.org/show_bug.cgi?id=193853

Reviewed by Simon Fraser.

• WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::FindController::updateFindIndicator):
There is no reason to scroll/zoom to the find indicator just because the
holes are up, we should only do it on initial indicator presentation.
This was a mistake in r178755 that was previously never exercised because
isShowingOverlay was always false.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/ios/FindControllerIOS.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-01-25  Tim Horton  <timothy_horton@apple.com>
+
+        Find-in-page on nyt.com scrolls around without touching the screen when find holes are visible
+        https://bugs.webkit.org/show_bug.cgi?id=193853
+
+        Reviewed by Simon Fraser.
+
+        * WebProcess/WebPage/ios/FindControllerIOS.mm:
+        (WebKit::FindController::updateFindIndicator):
+        There is no reason to scroll/zoom to the find indicator just because the
+        holes are up, we should only do it on initial indicator presentation.
+        This was a mistake in r178755 that was previously never exercised because
+        isShowingOverlay was always false.
+
 2019-01-25  Keith Rollin  <krollin@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm

@@ -106 +106 @@
     m_findIndicatorOverlay->setNeedsDisplay();
 
-    if (isShowingOverlay || shouldAnimate) {
+    if (shouldAnimate) {
         FloatRect visibleContentRect = m_webPage->mainFrameView()->unobscuredContentRectIncludingScrollbars();