Changeset 240537 in webkit

Timestamp:

Jan 25, 2019 5:46:50 PM (5 years ago)

Author:

jer.noble@apple.com

Message:

<video> elements not in the DOM should be allowed to AirPlay
​https://bugs.webkit.org/show_bug.cgi?id=193837
Source/WebCore:

<rdar://42559491>

Reviewed by Eric Carlson.

Test: media/airplay-allows-buffering.html

Some websites will switch between <video> elements backed by MSE to one backed by
a media file in order to implement an AirPlay control. But when a <video> element is
removed from the DOM and paused, further buffering is blocked. For some ports (namely
Cocoa ones), this keeps AirPlay from engaging. Relax this buffering restriction for
elements who have been asked to play wirelessly, but whose wireless playback has not
started yet.

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::dataBufferingPermitted const):
(WebCore::MediaElementSession::setShouldPlayToPlaybackTarget):

LayoutTests:

Reviewed by Eric Carlson.

• media/airplay-allows-buffering-expected.txt: Added.
• media/airplay-allows-buffering.html: Added.
• platform/ios/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/airplay-allows-buffering-expected.txt (added)
• LayoutTests/media/airplay-allows-buffering.html (added)
• LayoutTests/platform/ios/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/MediaElementSession.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-01-25  Jer Noble  <jer.noble@apple.com>
+
+        <video> elements not in the DOM should be allowed to AirPlay
+        https://bugs.webkit.org/show_bug.cgi?id=193837
+
+        Reviewed by Eric Carlson.
+
+        * media/airplay-allows-buffering-expected.txt: Added.
+        * media/airplay-allows-buffering.html: Added.
+        * platform/ios/TestExpectations:
+
 2019-01-25  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/platform/ios/TestExpectations

@@ -2458 +2458 @@
 
 media/accessibility-closed-captions-has-aria-owns.html
+media/airplay-allows-buffering.html
 media/airplay-autoplay.html
 media/airplay-target-availability.html

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-01-25  Jer Noble  <jer.noble@apple.com>
+
+        <video> elements not in the DOM should be allowed to AirPlay
+        https://bugs.webkit.org/show_bug.cgi?id=193837
+        <rdar://42559491>
+
+        Reviewed by Eric Carlson.
+
+        Test: media/airplay-allows-buffering.html
+
+        Some websites will switch between <video> elements backed by MSE to one backed by
+        a media file in order to implement an AirPlay control. But when a <video> element is
+        removed from the DOM and paused, further buffering is blocked. For some ports (namely
+        Cocoa ones), this keeps AirPlay from engaging. Relax this buffering restriction for
+        elements who have been asked to play wirelessly, but whose wireless playback has not
+        started yet.
+
+        * html/MediaElementSession.cpp:
+        (WebCore::MediaElementSession::dataBufferingPermitted const):
+        (WebCore::MediaElementSession::setShouldPlayToPlaybackTarget):
+
 2019-01-25  Keith Rollin  <krollin@apple.com>
 

trunk/Source/WebCore/html/MediaElementSession.cpp

@@ -386 +386 @@
         return true;
 
+#if ENABLE(WIRELESS_PLAYBACK_TARGET)
+    if (m_shouldPlayToPlaybackTarget)
+        return true;
+#endif
+
     if (m_elementIsHiddenUntilVisibleInViewport || m_elementIsHiddenBecauseItWasRemovedFromDOM || m_element.elementIsHidden())
         return false;
@@ -684 +689 @@
     INFO_LOG(LOGIDENTIFIER, shouldPlay);
     m_shouldPlayToPlaybackTarget = shouldPlay;
+    updateClientDataBuffering();
     client().setShouldPlayToPlaybackTarget(shouldPlay);
 }