Changeset 24055 in webkit

Timestamp:

Jul 6, 2007 3:06:46 AM (17 years ago)

Author:

bdash

Message:

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14400 Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube

Test: fast/forms/button-state-restore.html

• dom/Document.h: (WebCore::Document::isFormElementRegistered): Added.
• html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::closeRenderer): Restore saved form element state only if the element is registered with the document to have its state saved.

2007-07-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=14400 Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube

• fast/forms/button-state-restore-expected.txt: Added.
• fast/forms/button-state-restore.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/button-state-restore-expected.txt (added)
• LayoutTests/fast/forms/button-state-restore.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Document.h (modified) (1 diff)
• WebCore/html/HTMLGenericFormElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-07-06  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Maciej.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=14400
+          Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube
+
+        * fast/forms/button-state-restore-expected.txt: Added.
+        * fast/forms/button-state-restore.html: Added.
+
 2007-07-06  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-07-06  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Maciej.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=14400
+          Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube
+
+        Test: fast/forms/button-state-restore.html
+
+        * dom/Document.h:
+        (WebCore::Document::isFormElementRegistered): Added.
+        * html/HTMLGenericFormElement.cpp:
+        (WebCore::HTMLGenericFormElement::closeRenderer): Restore saved form
+        element state only if the element is registered with the document to
+        have its state saved.
+
 2007-07-06  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/dom/Document.h

@@ -296 +296 @@
     void registerFormElementWithState(HTMLGenericFormElement* e) { m_formElementsWithState.add(e); }
     void unregisterFormElementWithState(HTMLGenericFormElement* e) { m_formElementsWithState.remove(e); }
+    bool isFormElementRegistered(HTMLGenericFormElement* e) { return m_formElementsWithState.contains(e); }
     Vector<String> formElementsState() const;
     void setStateForNewFormElements(const Vector<String>&);

trunk/WebCore/html/HTMLGenericFormElement.cpp

@@ -209 +209 @@
 {
     Document* doc = document();
-    if (doc->hasStateForNewFormElements()) {
+    if (doc->isFormElementRegistered(this) && doc->hasStateForNewFormElements()) {
         String state;
         if (doc->takeStateForFormElement(name().impl(), type().impl(), state))