Changeset 240903 in webkit

Timestamp:

Feb 3, 2019 5:53:54 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r240896.
​https://bugs.webkit.org/show_bug.cgi?id=194202

"Fixes leaks, but is probably not the correct fix." (Requested
by ddkilzer on #webkit).

Reverted changeset:

"Leak of WTF::StringImpl under SymbolImpl::createNullSymbol()
(48 bytes) in com.apple.WebKit.WebContent running layout
tests"
​https://bugs.webkit.org/show_bug.cgi?id=193291
​https://trac.webkit.org/changeset/240896

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/text/SymbolImpl.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-02-03  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r240896.
+        https://bugs.webkit.org/show_bug.cgi?id=194202
+
+        "Fixes leaks, but is probably not the correct fix." (Requested
+        by ddkilzer on #webkit).
+
+        Reverted changeset:
+
+        "Leak of WTF::StringImpl under SymbolImpl::createNullSymbol()
+        (48 bytes) in com.apple.WebKit.WebContent running layout
+        tests"
+        https://bugs.webkit.org/show_bug.cgi?id=193291
+        https://trac.webkit.org/changeset/240896
+
 2019-02-02  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WTF/wtf/text/SymbolImpl.h

@@ -117 +117 @@
     }
 
-    ~SymbolImpl()
-    {
-        if (m_owner != StringImpl::empty())
-            m_owner->deref();
-        m_owner = nullptr;
-    }
-
     // The pointer to the owner string should be immediately following after the StringImpl layout,
     // since we would like to align the layout of SymbolImpl to the one of BufferSubstring StringImpl.