Changeset 240926 in webkit

Timestamp:

Feb 4, 2019 8:05:18 AM (5 years ago)

Author:

Wenson Hsieh

Message:

[iOS] Unable to make a selection in jsfiddle.net using arrow keys when requesting desktop site
Followup to ​https://bugs.webkit.org/show_bug.cgi?id=193758

Reviewed by Daniel Bates.

Put the iOS-specific behavior behind an EditingBehavior check, rather than a compile-time guard. No change in
behavior.

• editing/EditingBehavior.h:

(WebCore::EditingBehavior::shouldMoveSelectionToEndWhenFocusingTextInput const):

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setDefaultSelectionAfterFocus):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/EditingBehavior.h (modified) (1 diff)
• html/HTMLInputElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS] Unable to make a selection in jsfiddle.net using arrow keys when requesting desktop site
+        Followup to https://bugs.webkit.org/show_bug.cgi?id=193758
+
+        Reviewed by Daniel Bates.
+
+        Put the iOS-specific behavior behind an EditingBehavior check, rather than a compile-time guard. No change in
+        behavior.
+
+        * editing/EditingBehavior.h:
+        (WebCore::EditingBehavior::shouldMoveSelectionToEndWhenFocusingTextInput const):
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::setDefaultSelectionAfterFocus):
+
 2019-02-04  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/editing/EditingBehavior.h

@@ -94 +94 @@
     bool shouldAlwaysExtendSelectionFromExtentEndpoint() const { return m_type != EditingMacBehavior && m_type != EditingIOSBehavior; }
 
+    // On iOS, we don't want to select all the text when focusing a field. Instead, match platform behavior by going to the end of the line.
+    bool shouldMoveSelectionToEndWhenFocusingTextInput() const { return m_type == EditingIOSBehavior; }
+
 private:
     EditingBehaviorType m_type;

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -470 +470 @@
 {
     ASSERT(isTextField());
-#if PLATFORM(IOS_FAMILY)
-    // We don't want to select all the text on iOS when focusing a field. Instead, match platform behavior by going to the end of the line.
-    int start = std::numeric_limits<int>::max();
-    auto direction = SelectionHasForwardDirection;
-#else
     int start = 0;
     auto direction = SelectionHasNoDirection;
-#endif
+    auto* frame = document().frame();
+    if (frame && frame->editor().behavior().shouldMoveSelectionToEndWhenFocusingTextInput()) {
+        start = std::numeric_limits<int>::max();
+        direction = SelectionHasForwardDirection;
+    }
     setSelectionRange(start, std::numeric_limits<int>::max(), direction, revealMode, Element::defaultFocusTextStateChangeIntent());
 }