Changeset 241034 in webkit

Timestamp:

Feb 6, 2019 11:32:31 AM (5 years ago)

Author:

ddkilzer@apple.com

Message:

WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
<​https://webkit.org/b/194286>
<rdar://problem/47815558>

Reviewed by Alexey Proskuryakov.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willSendRequestForFrame): Use
WKRetainPtr<> to avoid leaking the WKDataRef.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-02-06  David Kilzer  <ddkilzer@apple.com>
+
+        WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
+        <https://webkit.org/b/194286>
+        <rdar://problem/47815558>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+        (WTR::InjectedBundlePage::willSendRequestForFrame): Use
+        WKRetainPtr<> to avoid leaking the WKDataRef.
+
 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp

@@ -1212 +1212 @@
         if (!body.isEmpty()) {
             CString cBody = body.utf8();
-            return WKURLRequestCopySettingHTTPBody(request, WKDataCreate(reinterpret_cast<const unsigned char*>(cBody.data()), cBody.length()));
+            WKRetainPtr<WKDataRef> body = adoptWK(WKDataCreate(reinterpret_cast<const unsigned char*>(cBody.data()), cBody.length()));
+            return WKURLRequestCopySettingHTTPBody(request, body.get());
         }
     }