Changeset 241598 in webkit

Timestamp:

Feb 15, 2019 11:06:47 AM (5 years ago)

Author:

youenn@apple.com

Message:

Performance should not fire events when its context is stopped
​https://bugs.webkit.org/show_bug.cgi?id=194689

Reviewed by Alex Christensen.

Stop the timer when its context is destroyed.
Add an assertion to ensure the timer does not fire after context is destroyed.

• page/Performance.cpp:

(WebCore::Performance::stop):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Performance.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-02-15  Youenn Fablet  <youenn@apple.com>
+
+        Performance should not fire events when its context is stopped
+        https://bugs.webkit.org/show_bug.cgi?id=194689
+
+        Reviewed by Alex Christensen.
+
+        Stop the timer when its context is destroyed.
+        Add an assertion to ensure the timer does not fire after context is destroyed.
+
+        * page/Performance.cpp:
+        (WebCore::Performance::stop):
+
 2019-02-15  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/page/Performance.cpp

@@ -65 +65 @@
 {
     m_performanceTimelineTaskQueue.close();
-
+    m_resourceTimingBufferFullTimer.stop();
     ContextDestructionObserver::contextDestroyed();
 }
@@ -212 +212 @@
 void Performance::resourceTimingBufferFullTimerFired()
 {
+    ASSERT(scriptExecutionContext());
+
     while (!m_backupResourceTimingBuffer.isEmpty()) {
         auto backupBuffer = WTFMove(m_backupResourceTimingBuffer);