Changeset 241638 in webkit


Ignore:
Timestamp:
Feb 15, 2019 6:03:32 PM (5 years ago)
Author:
Nikita Vasilyev
Message:

Web Inspector: Dark Mode: commas in CSS selectors are too dim
​https://bugs.webkit.org/show_bug.cgi?id=194729
<rdar://problem/48128592>

Reviewed by Matt Baker.

Use --text-color-tertiary for both light and dark modes.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:

(.spreadsheet-css-declaration):
(.spreadsheet-css-declaration .selector > span):
(@media (prefers-color-scheme: dark)):

  • UserInterface/Views/Variables.css:

(:root):

Location:
trunk/Source/WebInspectorUI
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r241636 r241638  
     12019-02-15  Nikita Vasilyev  <nvasilyev@apple.com>
     2
     3        Web Inspector: Dark Mode: commas in CSS selectors are too dim
     4        https://bugs.webkit.org/show_bug.cgi?id=194729
     5        <rdar://problem/48128592>
     6
     7        Reviewed by Matt Baker.
     8
     9        Use `--text-color-tertiary` for both light and dark modes.
     10
     11        * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
     12        (.spreadsheet-style-declaration-editor):
     13        * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:
     14        (.spreadsheet-css-declaration):
     15        (.spreadsheet-css-declaration .selector > span):
     16        (@media (prefers-color-scheme: dark)):
     17        * UserInterface/Views/Variables.css:
     18        (:root):
     19
    1202019-02-15  Nikita Vasilyev  <nvasilyev@apple.com>
    221

  • trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css

    r240559 r241638  
    2929    font-family: Menlo, monospace;
    3030    font-size: 11px;
    31     color: hsl(0, 0%, 70%);
     31    color: var(--text-color-tertiary);
    3232    -webkit-user-select: text;
    3333

  • trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css

    r239760 r241638  
    2929    font-family: Menlo, monospace;
    3030    font-size: 11px;
    31     color: hsl(0, 0%, 70%);
    32     background: white;
    33     border-bottom: 0.5px solid hsla(0, 0%, 0%, 0.2);
     31    color: var(--text-color-tertiary);
     32    background: var(--background-color-code);
     33    border-bottom: 0.5px solid var(--text-color-quaternary);
    3434    -webkit-user-select: text;
    3535}
    … …  
    101101
    102102.spreadsheet-css-declaration .selector > span {
    103     color: hsl(0, 0%, 50%);
     103    color: var(--text-color-secondary);
    104104}
    105105
    … …  
    135135
    136136@media (prefers-color-scheme: dark) {
    137     .spreadsheet-css-declaration {
    138         background: var(--background-color-code);
    139         color: var(--text-color-tertiary);
    140         color: hsl(0, 0%, 30%);
    141         border-bottom-color: var(--text-color-quaternary);
    142     }
    143 
    144137    .spreadsheet-css-declaration.locked {
    145138        background: var(--background-color);

  • trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css

    r240518 r241638  
    4040    --text-color-secondary: hsl(0, 0%, 50%);
    4141
     42    /* Disabled text/glyphs */
     43    --text-color-tertiary: hsl(0, 0%, 70%);
     44
    4245    /* Dividers, separators, background fills */
    4346    --text-color-quaternary: hsl(0, 0%, 85%);
Note: See TracChangeset for help on using the changeset viewer.