Changeset 241641 in webkit

Timestamp:

Feb 15, 2019 8:57:09 PM (5 years ago)

Author:

youenn@apple.com

Message:

NetworkDataTask should check its client before calling shouldCaptureExtraNetworkLoadMetrics
​https://bugs.webkit.org/show_bug.cgi?id=194732

Reviewed by Geoffrey Garen.

NetworkDataTask may be kept alive if refing it after its NetworkLoad is gone.
This might happen for instance in DownloadManager or when checking for TLS certificates.
In that case, if the NetworkLoad gets destroyed, it clears the client of the NetworkDataTask.
To ensure that NetworkDataTask does not try to use its client, add a null check.

• NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::shouldCaptureExtraNetworkLoadMetrics const):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/NetworkDataTask.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-02-15  Youenn Fablet  <youenn@apple.com>
+
+        NetworkDataTask should check its client before calling shouldCaptureExtraNetworkLoadMetrics
+        https://bugs.webkit.org/show_bug.cgi?id=194732
+
+        Reviewed by Geoffrey Garen.
+
+        NetworkDataTask may be kept alive if refing it after its NetworkLoad is gone.
+        This might happen for instance in DownloadManager or when checking for TLS certificates.
+        In that case, if the NetworkLoad gets destroyed, it clears the client of the NetworkDataTask.
+        To ensure that NetworkDataTask does not try to use its client, add a null check.
+
+        * NetworkProcess/NetworkDataTask.cpp:
+        (WebKit::NetworkDataTask::shouldCaptureExtraNetworkLoadMetrics const):
+
 2019-02-15  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp

@@ -115 +115 @@
 bool NetworkDataTask::shouldCaptureExtraNetworkLoadMetrics() const
 {
-    return m_client->shouldCaptureExtraNetworkLoadMetrics();
+    return m_client ? m_client->shouldCaptureExtraNetworkLoadMetrics() : false;
 }