Changeset 241740 in webkit

Timestamp:

Feb 18, 2019 2:45:55 PM (5 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Styles: typing ";" shouldn't focus on the next property when there's open parenthesis or comment
​https://bugs.webkit.org/show_bug.cgi?id=194789

Reviewed by Matt Baker.

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._handleValueBeforeInput):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SpreadsheetStyleProperty.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-02-18  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Styles: typing ";" shouldn't focus on the next property when there's open parenthesis or comment
+        https://bugs.webkit.org/show_bug.cgi?id=194789
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/SpreadsheetStyleProperty.js:
+        (WI.SpreadsheetStyleProperty.prototype._handleValueBeforeInput):
+
 2019-02-18  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js

@@ -728 +728 @@
             return;
 
-        // Find the first and last index (if any) of a quote character to ensure that the string
-        // doesn't contain unbalanced quotes. If so, then there's no way that the semicolon could be
-        // part of a string within the value, so we can assume that it's the property "terminator".
-        const quoteRegex = /["']/g;
-        let start = -1;
-        let end = text.length;
-        let match = null;
-        while (match = quoteRegex.exec(text)) {
-            if (start < 0)
-                start = match.index;
-            end = match.index + 1;
-        }
-
-        if (start !== -1 && !text.substring(start, end).hasMatchingEscapedQuotes())
+        let unbalancedCharacters = WI.CSSCompletions.completeUnbalancedValue(text);
+        if (unbalancedCharacters)
             return;