Changeset 241875 in webkit

Timestamp:

Feb 21, 2019 11:59:01 AM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Canvas: recordings with a single frame sometimes missing TreeElement
​https://bugs.webkit.org/show_bug.cgi?id=194687

Reviewed by Joseph Pecoraro.

• UserInterface/Views/CanvasSidebarPanel.js:

(WI.CanvasSidebarPanel):
Wait until the entire Recording has been processed before setting the selected action.

• UserInterface/Views/CanvasSidebarPanel.css:

(.sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content):
Drive-by: ensure that the recording TreeOutline container element has the full height to
take advantage of for virtualization.

• UserInterface/Views/RecordingStateDetailsSidebarPanel.js:

(WI.RecordingStateDetailsSidebarPanel.prototype.set recording):
Drive-by: clear the DataGrid list when changing recordings since we removed all subviews.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CanvasSidebarPanel.css (modified) (1 diff)
• UserInterface/Views/CanvasSidebarPanel.js (modified) (1 diff)
• UserInterface/Views/RecordingStateDetailsSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-02-21  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Canvas: recordings with a single frame sometimes missing TreeElement
+        https://bugs.webkit.org/show_bug.cgi?id=194687
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/CanvasSidebarPanel.js:
+        (WI.CanvasSidebarPanel):
+        Wait until the entire `Recording` has been processed before setting the selected action.
+
+        * UserInterface/Views/CanvasSidebarPanel.css:
+        (.sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content):
+        Drive-by: ensure that the recording `TreeOutline` container element has the full height to
+        take advantage of for virtualization.
+
+        * UserInterface/Views/RecordingStateDetailsSidebarPanel.js:
+        (WI.RecordingStateDetailsSidebarPanel.prototype.set recording):
+        Drive-by: clear the `DataGrid` list when changing recordings since we removed all subviews.
+
 2019-02-21  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css

@@ -49 +49 @@
 
 .sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content {
+    flex-grow: 1;
     overflow-y: scroll;
 }

trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js

@@ -581 +581 @@
         this._createRecordingActionTreeElement(action, index, isInitialStateAction ? this._recordingTreeOutline : this._recordingTreeOutline.children.lastValue);
 
-        if (isInitialStateAction && !this._recording[WI.CanvasSidebarPanel.SelectedActionSymbol])
-            this.action = action;
+        if (this._recording.ready && !this._recording[WI.CanvasSidebarPanel.SelectedActionSymbol])
+            this.action = this._recording.actions[0];
 
         if (action === this._recording.actions.lastValue && this._recordingProcessingOptionsContainer) {

trunk/Source/WebInspectorUI/UserInterface/Views/RecordingStateDetailsSidebarPanel.js

@@ -59 +59 @@
         for (let subview of this.contentView.subviews)
             this.contentView.removeSubview(subview);
+
+        this._dataGrids = [];
     }