Changeset 241905 in webkit
- Timestamp:
- Feb 21, 2019 2:50:14 PM (5 years ago)
- Location:
- trunk/Tools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r241899 r241905 1 2019-02-21 Tim Horton <timothy_horton@apple.com> 2 3 Fix ProcessSwap.PageOverlayLayerPersistence on macOS 4 5 * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: 6 We can't find the UI-side layer on macOS because we don't use UI-side compositing. 7 We could force on UI-side compositing, but I feel like the test might be more 8 valuable exercising the normal path on each platform (though the original 9 bug was also UI-side specific). Though we can't validate that the overlay 10 layer was installed successfully, there are layout tests that do that. 11 1 12 2019-02-21 Tim Horton <timothy_horton@apple.com> 2 13 -
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
r241899 r241905 5182 5182 [webView waitForNextPresentationUpdate]; 5183 5183 5184 // We can only look for the overlay layer in the UI-side layer tree on platforms 5185 // that use UI-side compositing. 5186 #if PLATFORM(MAC) 5184 5187 EXPECT_TRUE(hasOverlay([webView layer])); 5188 #endif 5185 5189 5186 5190 request = adoptNS([NSURLRequest requestWithURL:[NSURL URLWithString:@"pson://www.apple.com/page-overlay"]]); … … 5196 5200 [webView waitForNextPresentationUpdate]; 5197 5201 5202 #if PLATFORM(MAC) 5198 5203 EXPECT_TRUE(hasOverlay([webView layer])); 5204 #endif 5199 5205 } 5200 5206
Note: See TracChangeset
for help on using the changeset viewer.