Changeset 242065 in webkit


Ignore:
Timestamp:
Feb 25, 2019 6:52:33 PM (5 years ago)
Author:
aakash_jain@apple.com
Message:

[ews-app] Remove BuilderMapping table
https://bugs.webkit.org/show_bug.cgi?id=194961

Reviewed by Stephanie Lewis.

Store builder name directly in build table, instead of having a separate
table for it.

  • BuildSlaveSupport/ews-app/ews/models/init.py:
  • BuildSlaveSupport/ews-app/ews/models/build.py:
  • BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
  • BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
Location:
trunk/Tools
Files:
1 deleted
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py

    r240361 r242065  
    1 from buildermapping import *
    21from build import *
    32from patch import *
  • trunk/Tools/BuildSlaveSupport/ews-app/ews/models/build.py

    r241561 r242065  
    2727from django.db import models
    2828from ews.config import ERR_UNEXPECTED, SUCCESS
    29 from ews.models.buildermapping import BuilderMapping
    3029from ews.models.patch import Patch
    3130import ews.common.util as util
     
    3736    patch = models.ForeignKey(Patch, on_delete=models.CASCADE)
    3837    build_id = models.IntegerField(primary_key=True)
    39     builder = models.ForeignKey(BuilderMapping, on_delete=models.DO_NOTHING)
     38    builder_id = models.IntegerField()
     39    builder_name = models.TextField()
     40    builder_display_name = models.TextField()
    4041    number = models.IntegerField()
    4142    result = models.IntegerField(null=True, blank=True)
  • trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

    r241562 r242065  
    2727from django.views import View
    2828from django.views.decorators.clickjacking import xframe_options_exempt
    29 from ews.models.buildermapping import BuilderMapping
    3029from ews.models.patch import Patch
    3130import ews.config as config
     
    3433class StatusBubble(View):
    3534    def _build_bubble(self, build, patch):
    36         try:
    37             builder_display_name = build.builder.display_name
    38             builder_full_name = build.builder.builder_name
    39         except BuilderMapping.DoesNotExist:
    40             builder_display_name = build.builder_id
    41             builder_full_name = ''
     35        builder_display_name = build.builder_display_name
     36        builder_full_name = build.builder_name
    4237
    4338        bubble = {
  • trunk/Tools/ChangeLog

    r242056 r242065  
     12019-02-25  Aakash Jain  <aakash_jain@apple.com>
     2
     3        [ews-app] Remove BuilderMapping table
     4        https://bugs.webkit.org/show_bug.cgi?id=194961
     5
     6        Reviewed by Stephanie Lewis.
     7
     8        Store builder name directly in build table, instead of having a separate
     9        table for it.
     10
     11        * BuildSlaveSupport/ews-app/ews/models/__init__.py:
     12        * BuildSlaveSupport/ews-app/ews/models/build.py:
     13        * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
     14        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
     15
    1162019-02-25  John Wilander  <wilander@apple.com>
    217
Note: See TracChangeset for help on using the changeset viewer.