Changeset 242131 in webkit

Timestamp:

Feb 27, 2019 10:05:06 AM (5 years ago)

Author:

achristensen@apple.com

Message:

Silence log after r242122
​https://bugs.webkit.org/show_bug.cgi?id=195074

• UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::databasePath const):
m_localStorageDirectory can now be null for ephemeral sessions.
This is not a failure to create a directory and needs no log.
This fixes the WKWebView.InitializingWebViewWithEphemeralStorageDoesNotLog API test.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-02-27  Alex Christensen  <achristensen@webkit.org>
+
+        Silence log after r242122
+        https://bugs.webkit.org/show_bug.cgi?id=195074
+
+        * UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:
+        (WebKit::LocalStorageDatabaseTracker::databasePath const):
+        m_localStorageDirectory can now be null for ephemeral sessions.
+        This is not a failure to create a directory and needs no log.
+        This fixes the WKWebView.InitializingWebViewWithEphemeralStorageDoesNotLog API test.
+
 2019-02-27  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp

@@ -152 +152 @@
 {
     if (!SQLiteFileSystem::ensureDatabaseDirectoryExists(m_localStorageDirectory)) {
-        LOG_ERROR("Unable to create LocalStorage database path %s", m_localStorageDirectory.utf8().data());
+        if (!m_localStorageDirectory.isNull())
+            LOG_ERROR("Unable to create LocalStorage database path %s", m_localStorageDirectory.utf8().data());
         return String();
     }