Changeset 242244 in webkit

Timestamp:

Feb 28, 2019 5:11:56 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Timelines: don't show the auto-stop UI when not inspecting a page
​https://bugs.webkit.org/show_bug.cgi?id=195192

Reviewed by Joseph Pecoraro.

• UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):
(WI.TimelineRecordingContentView.prototype.get navigationItems):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TimelineRecordingContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-02-28  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Timelines: don't show the auto-stop UI when not inspecting a page
+        https://bugs.webkit.org/show_bug.cgi?id=195192
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WI.TimelineRecordingContentView):
+        (WI.TimelineRecordingContentView.prototype.get navigationItems):
+
 2019-02-28  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js

@@ -57 +57 @@
         this.addSubview(this._timelineContentBrowser);
 
-        this._autoStopCheckboxNavigationItem = new WI.CheckboxNavigationItem("auto-stop-recording", WI.UIString("Stop recording once page loads"), WI.settings.timelinesAutoStop.value);
-        this._autoStopCheckboxNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
-        this._autoStopCheckboxNavigationItem.addEventListener(WI.CheckboxNavigationItem.Event.CheckedDidChange, this._handleAutoStopCheckboxCheckedDidChange, this);
-
-        WI.settings.timelinesAutoStop.addEventListener(WI.Setting.Event.Changed, this._handleTimelinesAutoStopSettingChanged, this);
+        if (WI.sharedApp.debuggableType === WI.DebuggableType.Web) {
+            this._autoStopCheckboxNavigationItem = new WI.CheckboxNavigationItem("auto-stop-recording", WI.UIString("Stop recording once page loads"), WI.settings.timelinesAutoStop.value);
+            this._autoStopCheckboxNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
+            this._autoStopCheckboxNavigationItem.addEventListener(WI.CheckboxNavigationItem.Event.CheckedDidChange, this._handleAutoStopCheckboxCheckedDidChange, this);
+
+            WI.settings.timelinesAutoStop.addEventListener(WI.Setting.Event.Changed, this._handleTimelinesAutoStopSettingChanged, this);
+        }
 
         this._clearTimelineNavigationItem = new WI.ButtonNavigationItem("clear-timeline", WI.UIString("Clear Timeline (%s)").format(WI.clearKeyboardShortcut.displayName), "Images/NavigationItemTrash.svg", 15, 15);
@@ -162 +164 @@
     get navigationItems()
     {
-        return [
-            this._autoStopCheckboxNavigationItem,
-            new WI.DividerNavigationItem,
-            this._clearTimelineNavigationItem,
-        ];
+        let navigationItems = [];
+        if (this._autoStopCheckboxNavigationItem)
+            navigationItems.push(this._autoStopCheckboxNavigationItem);
+        navigationItems.push(new WI.DividerNavigationItem);
+        navigationItems.push(this._clearTimelineNavigationItem);
+        return navigationItems;
     }