Changeset 242370 in webkit


Ignore:
Timestamp:
Mar 4, 2019 12:23:49 PM (5 years ago)
Author:
Devin Rousso
Message:

Web Inspector: Toggling Timeline "Stop when page loads" to on should stop (immediately or soon) any active recording if already past the load event
https://bugs.webkit.org/show_bug.cgi?id=195239

Reviewed by Joseph Pecoraro.

  • UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype._handleTimelinesAutoStopSettingChanged):

Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r242322 r242370  
     12019-03-04  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: Toggling Timeline "Stop when page loads" to on should stop (immediately or soon) any active recording if already past the load event
     4        https://bugs.webkit.org/show_bug.cgi?id=195239
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        * UserInterface/Controllers/TimelineManager.js:
     9        (WI.TimelineManager.prototype._handleTimelinesAutoStopSettingChanged):
     10
    1112019-03-02  Devin Rousso  <drousso@apple.com>
    212
  • trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js

    r241982 r242370  
    957957            return;
    958958
    959         if (WI.settings.timelinesAutoStop.value)
    960             this._resetAutoRecordingMaxTimeTimeout();
    961         else
     959        if (WI.settings.timelinesAutoStop.value) {
     960            if (this._mainResourceForAutoCapturing && !isNaN(this._mainResourceForAutoCapturing.parentFrame.loadEventTimestamp))
     961                this._stopAutoRecordingSoon();
     962            else
     963                this._resetAutoRecordingMaxTimeTimeout();
     964            this._resetAutoRecordingDeadTimeTimeout();
     965        } else
    962966            this.relaxAutoStop();
    963967    }
Note: See TracChangeset for help on using the changeset viewer.