Changeset 24238 in webkit
- Timestamp:
- Jul 12, 2007 7:01:41 AM (17 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r24236 r24238 1 2007-07-12 Mark Rowe <mrowe@apple.com> 2 3 Reviewed by Ada. 4 5 <rdar://problem/5329877> REGRESSION: Document::setTransformSource leaks an xmlDocPtr if called more than once per document 6 7 * dom/Document.cpp: 8 (WebCore::Document::setTransformSource): Free any existing m_transformSource before overwriting it, rather than simply leaking it. 9 * dom/Document.h: 10 1 11 2007-07-12 Holger Hans Peter Freyther <zecke@selfish.org> 2 12 -
trunk/WebCore/dom/Document.cpp
r24148 r24238 3204 3204 } 3205 3205 3206 void Document::setTransformSource(void* doc) 3207 { 3208 if (doc == m_transformSource) 3209 return; 3210 3211 xmlFreeDoc((xmlDocPtr)m_transformSource); 3212 m_transformSource = doc; 3213 } 3214 3206 3215 #endif 3207 3216 -
trunk/WebCore/dom/Document.h
r24146 r24238 600 600 #if ENABLE(XSLT) 601 601 void applyXSLTransform(ProcessingInstruction* pi); 602 void setTransformSource(void* doc) { m_transformSource = doc; }602 void setTransformSource(void* doc); 603 603 const void* transformSource() { return m_transformSource; } 604 604 PassRefPtr<Document> transformSourceDocument() { return m_transformSourceDocument; } 605 void setTransformSourceDocument(Document *doc) { m_transformSourceDocument = doc; }605 void setTransformSourceDocument(Document* doc) { m_transformSourceDocument = doc; } 606 606 #endif 607 607 -
trunk/WebKitTools/ChangeLog
r24235 r24238 1 2007-07-12 Mark Rowe <mrowe@apple.com> 2 3 Reviewed by Ada. 4 5 Remove leak suppression for xmlDocPtrForString now that <rdar://problem/5329877> is fixed. 6 7 * Scripts/run-webkit-tests: 8 1 9 2007-07-12 Geoffrey Garen <ggaren@apple.com> 2 10 -
trunk/WebKitTools/Scripts/run-webkit-tests
r24235 r24238 927 927 push @callStacksToExclude, ( 928 928 "glvmInitializeLLVM", # leak in OpenGL, Radar 5329956 929 "xmlDocPtrForString", # leak in libxml2, Radar 5329877930 929 "GetProcessForPID", # leak in Process Manager, Radar 5329842 931 930 "HIView::SendGetPartRegionOrShape", # leak in High Level Toolbox, Radars 5329755 & 5329717
Note: See TracChangeset
for help on using the changeset viewer.