Changeset 24238 in webkit


Ignore:
Timestamp:
Jul 12, 2007 7:01:41 AM (17 years ago)
Author:
bdash
Message:

2007-07-12 Mark Rowe <mrowe@apple.com>

Reviewed by Ada.

<rdar://problem/5329877> REGRESSION: Document::setTransformSource leaks an xmlDocPtr if called more than once per document

  • dom/Document.cpp: (WebCore::Document::setTransformSource): Free any existing m_transformSource before overwriting it, rather than simply leaking it.
  • dom/Document.h:

2007-07-12 Mark Rowe <mrowe@apple.com>

Reviewed by Ada.

Remove leak suppression for xmlDocPtrForString now that <rdar://problem/5329877> is fixed.

  • Scripts/run-webkit-tests:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r24236 r24238  
     12007-07-12  Mark Rowe  <mrowe@apple.com>
     2
     3        Reviewed by Ada.
     4
     5        <rdar://problem/5329877> REGRESSION: Document::setTransformSource leaks an xmlDocPtr if called more than once per document
     6
     7        * dom/Document.cpp:
     8        (WebCore::Document::setTransformSource): Free any existing m_transformSource before overwriting it, rather than simply leaking it.
     9        * dom/Document.h:
     10
    1112007-07-12  Holger Hans Peter Freyther  <zecke@selfish.org>
    212
  • trunk/WebCore/dom/Document.cpp

    r24148 r24238  
    32043204}
    32053205
     3206void Document::setTransformSource(void* doc)
     3207{
     3208    if (doc == m_transformSource)
     3209        return;
     3210
     3211    xmlFreeDoc((xmlDocPtr)m_transformSource);
     3212    m_transformSource = doc;
     3213}
     3214
    32063215#endif
    32073216
  • trunk/WebCore/dom/Document.h

    r24146 r24238  
    600600#if ENABLE(XSLT)
    601601    void applyXSLTransform(ProcessingInstruction* pi);
    602     void setTransformSource(void* doc) { m_transformSource = doc; }
     602    void setTransformSource(void* doc);
    603603    const void* transformSource() { return m_transformSource; }
    604604    PassRefPtr<Document> transformSourceDocument() { return m_transformSourceDocument; }
    605     void setTransformSourceDocument(Document *doc) { m_transformSourceDocument = doc; }
     605    void setTransformSourceDocument(Document* doc) { m_transformSourceDocument = doc; }
    606606#endif
    607607
  • trunk/WebKitTools/ChangeLog

    r24235 r24238  
     12007-07-12  Mark Rowe  <mrowe@apple.com>
     2
     3        Reviewed by Ada.
     4
     5        Remove leak suppression for xmlDocPtrForString now that <rdar://problem/5329877> is fixed.
     6
     7        * Scripts/run-webkit-tests:
     8
    192007-07-12  Geoffrey Garen  <ggaren@apple.com>
    210
  • trunk/WebKitTools/Scripts/run-webkit-tests

    r24235 r24238  
    927927        push @callStacksToExclude, (
    928928            "glvmInitializeLLVM", # leak in OpenGL, Radar 5329956
    929             "xmlDocPtrForString", # leak in libxml2, Radar 5329877
    930929            "GetProcessForPID", # leak in Process Manager, Radar 5329842
    931930            "HIView::SendGetPartRegionOrShape", # leak in High Level Toolbox, Radars 5329755 & 5329717
Note: See TracChangeset for help on using the changeset viewer.