Changeset 242398 in webkit

Timestamp:

Mar 4, 2019 3:49:58 PM (5 years ago)

Author:

jiewen_tan@apple.com

Message:

Unreviewed, a followup after r242336

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::webViewDidMoveToWindow):
Copy the list of observers before iterating it to avoid observers modifying the list.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-04  Jiewen Tan  <jiewen_tan@apple.com>
+
+        Unreviewed, a followup after r242336
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::webViewDidMoveToWindow):
+        Copy the list of observers before iterating it to avoid observers modifying the list.
+
 2019-03-04  Truitt Savell  <tsavell@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -8796 +8796 @@
 void WebPageProxy::webViewDidMoveToWindow()
 {
-    for (const auto& observer : m_webViewDidMoveToWindowObservers) {
+    auto observersCopy = m_webViewDidMoveToWindowObservers;
+    for (const auto& observer : observersCopy) {
         if (!observer.value)
             continue;