Changeset 242763 in webkit
- Timestamp:
- Mar 11, 2019 6:58:17 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r242759 r242763 1 2019-03-11 Zalan Bujtas <zalan@apple.com> 2 3 [Synthetic Click] Dispatch mouseout soon after mouseup 4 https://bugs.webkit.org/show_bug.cgi?id=195575 5 <rdar://problem/47093049> 6 7 Reviewed by Simon Fraser. 8 9 * fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click-expected.txt: Added. 10 * fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html: Added. 11 1 12 2019-03-11 Justin Fan <justin_fan@apple.com> 2 13 -
trunk/LayoutTests/fast/events/touch/ios/content-observation/visibility-change-happens-while-in-mousemoved.html
r242635 r242763 46 46 }, false); 47 47 48 becomesVisible.addEventListener("click", function( event ) { 48 tapthis.addEventListener("mouseout", function( event ) { 49 result.innerHTML = result.innerHTML + " mouseout should NOT be triggered "; 50 }, false); 51 52 becomesVisible.addEventListener("click", function( event ) { 49 53 result.innerHTML = "clicked hidden"; 50 54 }, false); -
trunk/Source/WebCore/ChangeLog
r242761 r242763 1 2019-03-11 Zalan Bujtas <zalan@apple.com> 2 3 [Synthetic Click] Dispatch mouseout soon after mouseup 4 https://bugs.webkit.org/show_bug.cgi?id=195575 5 <rdar://problem/47093049> 6 7 Reviewed by Simon Fraser. 8 9 Let's fire a mouseout event when a click is submitted as the result of a tap. It helps to dismiss content which would otherwise require you to move the mouse (cases like control bar on youtube.com). 10 11 Test: fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html 12 13 * page/EventHandler.h: 14 * page/ios/EventHandlerIOS.mm: 15 (WebCore::EventHandler::dispatchFakeMouseOut): 16 1 17 2019-03-11 Youenn Fablet <youenn@apple.com> 2 18 -
trunk/Source/WebCore/page/EventHandler.cpp
r242137 r242763 1979 1979 if (onlyUpdateScrollbars) { 1980 1980 if (shouldSendMouseEventsToInactiveWindows()) 1981 updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, true);1981 updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, FireMouseOverOut::Yes); 1982 1982 1983 1983 return true; … … 1994 1994 if (newSubframe) { 1995 1995 // Update over/out state before passing the event to the subframe. 1996 updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, true);1996 updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, FireMouseOverOut::Yes); 1997 1997 1998 1998 // Event dispatch in updateMouseEventTargetNode may have caused the subframe of the target … … 2477 2477 } 2478 2478 2479 void EventHandler::updateMouseEventTargetNode(Node* targetNode, const PlatformMouseEvent& platformMouseEvent, boolfireMouseOverOut)2479 void EventHandler::updateMouseEventTargetNode(Node* targetNode, const PlatformMouseEvent& platformMouseEvent, FireMouseOverOut fireMouseOverOut) 2480 2480 { 2481 2481 Ref<Frame> protectedFrame(m_frame); … … 2495 2495 2496 2496 // Fire mouseout/mouseover if the mouse has shifted to a different node. 2497 if (fireMouseOverOut ) {2497 if (fireMouseOverOut == FireMouseOverOut::Yes) { 2498 2498 auto scrollableAreaForLastNode = enclosingScrollableArea(m_lastElementUnderMouse.get()); 2499 2499 auto scrollableAreaForNodeUnderMouse = enclosingScrollableArea(m_elementUnderMouse.get()); … … 2589 2589 view->disableLayerFlushThrottlingTemporarilyForInteraction(); 2590 2590 2591 updateMouseEventTargetNode(targetNode, platformMouseEvent, setUnder );2591 updateMouseEventTargetNode(targetNode, platformMouseEvent, setUnder ? FireMouseOverOut::Yes : FireMouseOverOut::No); 2592 2592 2593 2593 if (m_elementUnderMouse && !m_elementUnderMouse->dispatchMouseEvent(platformMouseEvent, eventType, clickCount)) -
trunk/Source/WebCore/page/EventHandler.h
r241723 r242763 242 242 #if PLATFORM(IOS_FAMILY) 243 243 void defaultTouchEventHandler(Node&, TouchEvent&); 244 WEBCORE_EXPORT void dispatchSyntheticMouseOut(const PlatformMouseEvent&); 244 245 #endif 245 246 … … 405 406 Node* nodeUnderMouse() const; 406 407 407 void updateMouseEventTargetNode(Node*, const PlatformMouseEvent&, bool fireMouseOverOut);408 void fireMouseOverOut(bool fireMouseOver = true, bool fireMouseOut = true, bool updateLastNodeUnderMouse = true);409 408 enum class FireMouseOverOut { No, Yes }; 409 void updateMouseEventTargetNode(Node*, const PlatformMouseEvent&, FireMouseOverOut); 410 410 411 MouseEventWithHitTestResults prepareMouseEvent(const HitTestRequest&, const PlatformMouseEvent&); 411 412 -
trunk/Source/WebCore/page/ios/EventHandlerIOS.mm
r242340 r242763 516 516 } 517 517 518 void EventHandler::dispatchSyntheticMouseOut(const PlatformMouseEvent& platformMouseEvent) 519 { 520 updateMouseEventTargetNode(nullptr, platformMouseEvent, FireMouseOverOut::Yes); 521 } 522 518 523 bool EventHandler::passMousePressEventToSubframe(MouseEventWithHitTestResults& mev, Frame* subframe) 519 524 { -
trunk/Source/WebKit/ChangeLog
r242762 r242763 1 2019-03-11 Zalan Bujtas <zalan@apple.com> 2 3 [Synthetic Click] Dispatch mouseout soon after mouseup 4 https://bugs.webkit.org/show_bug.cgi?id=195575 5 <rdar://problem/47093049> 6 7 Reviewed by Simon Fraser. 8 9 * WebProcess/WebPage/ios/WebPageIOS.mm: 10 (WebKit::WebPage::completeSyntheticClick): 11 1 12 2019-03-11 Tim Horton <timothy_horton@apple.com> 2 13 -
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
r242757 r242763 641 641 elementDidRefocus(*newFocusedElement); 642 642 643 nodeRespondingToClick.document().frame()->eventHandler().dispatchSyntheticMouseOut(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::NoType, 0, shiftKey, ctrlKey, altKey, metaKey, WallTime::now(), 0, WebCore::NoTap)); 644 if (m_isClosed) 645 return; 646 643 647 if (!tapWasHandled || !nodeRespondingToClick.isElementNode()) 644 648 send(Messages::WebPageProxy::DidNotHandleTapAsClick(roundedIntPoint(location)));
Note: See TracChangeset
for help on using the changeset viewer.