Changeset 242784 in webkit

Timestamp:

Mar 11, 2019 11:58:20 PM (5 years ago)

Author:

rniwa@webkit.org

Message:

Remove OS X Server QuickTime plugin quirks
​https://bugs.webkit.org/show_bug.cgi?id=195607

Reviewed by Brent Fulgham.

r87244 added a site specific quirk for Mac OS X Sever wiki pages.
However, the issue has since been resolved as of OS X Mountain Lion,
of which Apple has ended the support in September 2015.

Because the latest versions of Safari no longer supports non-Flash plugins,
the only scenario in which this quirk comes into play is when a third party app
which embeds WKWebView or WebKitLegacy loaded web pages on a OS X Server
running OS X Mountain Lion or earlier.

Given these observations, it's probably safe to remove this quirk from WebKit.

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasFallbackContent const):
(WebCore::HTMLObjectElement::hasValidClassId):
(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Deleted.

• html/HTMLObjectElement.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLObjectElement.cpp (modified) (1 diff)
• html/HTMLObjectElement.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-03-11  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Remove OS X Server QuickTime plugin quirks
+        https://bugs.webkit.org/show_bug.cgi?id=195607
+
+        Reviewed by Brent Fulgham.
+
+        r87244 added a site specific quirk for Mac OS X Sever wiki pages.
+        However, the issue has since been resolved as of OS X Mountain Lion,
+        of which Apple has ended the support in September 2015.
+
+        Because the latest versions of Safari no longer supports non-Flash plugins,
+        the only scenario in which this quirk comes into play is when a third party app
+        which embeds WKWebView or WebKitLegacy loaded web pages on a OS X Server
+        running OS X Mountain Lion or earlier.
+
+        Given these observations, it's probably safe to remove this quirk from WebKit.
+
+        * html/HTMLObjectElement.cpp:
+        (WebCore::HTMLObjectElement::hasFallbackContent const):
+        (WebCore::HTMLObjectElement::hasValidClassId):
+        (WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Deleted.
+        * html/HTMLObjectElement.h:
+
 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/WebCore/html/HTMLObjectElement.cpp

@@ -225 +225 @@
     return false;
 }
-    
-bool HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk()
-{
-    // This site-specific hack maintains compatibility with Mac OS X Wiki Server,
-    // which embeds QuickTime movies using an object tag containing QuickTime's
-    // ActiveX classid. Treat this classid as valid only if OS X Server's unique
-    // 'generator' meta tag is present. Only apply this quirk if there is no
-    // fallback content, which ensures the quirk will disable itself if Wiki
-    // Server is updated to generate an alternate embed tag as fallback content.
-
-    if (!document().page()
-        || !document().page()->settings().needsSiteSpecificQuirks()
-        || hasFallbackContent()
-        || !equalLettersIgnoringASCIICase(attributeWithoutSynchronization(classidAttr), "clsid:02bf25d5-8c17-4b23-bc80-d3488abddc6b"))
-        return false;
-
-    for (auto& metaElement : descendantsOfType<HTMLMetaElement>(document())) {
-        if (equalLettersIgnoringASCIICase(metaElement.name(), "generator") && startsWithLettersIgnoringASCIICase(metaElement.content(), "mac os x server web services server"))
-            return true;
-    }
-
-    return false;
-}
-    
+
 bool HTMLObjectElement::hasValidClassId()
 {
     if (MIMETypeRegistry::isJavaAppletMIMEType(serviceType()) && protocolIs(attributeWithoutSynchronization(classidAttr), "java"))
-        return true;
-    
-    if (shouldAllowQuickTimeClassIdQuirk())
         return true;
 

trunk/Source/WebCore/html/HTMLObjectElement.h

@@ -85 +85 @@
     // so that we can better share code between <object> and <embed>.
     void parametersForPlugin(Vector<String>& paramNames, Vector<String>& paramValues, String& url, String& serviceType);
-    
-    bool shouldAllowQuickTimeClassIdQuirk();
+
     bool hasValidClassId();