Changeset 242821 in webkit

Timestamp:

Mar 12, 2019 1:10:32 PM (5 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Keyboard shortcut for settings tab too greedy on non-US keyboards
​https://bugs.webkit.org/show_bug.cgi?id=192947
<rdar://problem/46886779>

Reviewed by Devin Rousso.

• UserInterface/Base/Main.js:

(WI._showSettingsTab):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Main.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-03-12  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Keyboard shortcut for settings tab too greedy on non-US keyboards
+        https://bugs.webkit.org/show_bug.cgi?id=192947
+        <rdar://problem/46886779>
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Base/Main.js:
+        (WI._showSettingsTab):
+
 2019-03-12  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -714 +714 @@
 WI._showSettingsTab = function(event)
 {
-    this.tabBrowser.showTabForContentView(this.settingsTabContentView);
+    if (event.keyIdentifier === "U+002C") // ","
+        this.tabBrowser.showTabForContentView(this.settingsTabContentView);
 };