Changeset 242884 in webkit
- Timestamp:
- Mar 13, 2019 10:03:42 AM (5 years ago)
- Location:
- trunk/Tools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py
r241485 r242884 21 21 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 22 22 23 from future.utils import lrange 24 23 25 import logging 24 26 import os … … 33 35 34 36 class Buildbot(): 37 # Buildbot status codes referenced from https://github.com/buildbot/buildbot/blob/master/master/buildbot/process/results.py 38 ALL_RESULTS = lrange(7) 39 SUCCESS, WARNINGS, FAILURE, SKIPPED, EXCEPTION, RETRY, CANCELLED = ALL_RESULTS 40 35 41 @classmethod 36 42 def send_patch_to_buildbot(cls, patch_path, properties=[]): -
trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
r242880 r242884 29 29 from django.views import View 30 30 from django.views.decorators.clickjacking import xframe_options_exempt 31 from ews.common.buildbot import Buildbot 31 32 from ews.models.patch import Patch 32 33 import ews.config as config … … 58 59 if build.result is None: 59 60 bubble["state"] = "started" 60 elif build.result == 0: # SUCCESS61 elif build.result == Buildbot.SUCCESS: 61 62 bubble["state"] = "pass" 62 elif build.result == 1: # WARNINGS63 elif build.result == Buildbot.WARNINGS: 63 64 bubble["state"] = "pass" 64 elif build.result == 2: # FAILURE65 elif build.result == Buildbot.FAILURE: 65 66 bubble["state"] = "fail" 66 elif build.result == 3: # SKIPPED67 elif build.result == Buildbot.SKIPPED: 67 68 bubble["state"] = "none" 68 elif build.result == 4: # EXCEPTION69 elif build.result == Buildbot.EXCEPTION: 69 70 bubble["state"] = "error" 70 elif build.result == 5: # RETRY71 elif build.result == Buildbot.RETRY: 71 72 bubble["state"] = "provisional-fail" 72 73 else: … … 86 87 87 88 def _should_show_bubble_for_build(self, build): 88 if build and build.result == 3and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string):89 if build and build.result == Buildbot.SKIPPED and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string): 89 90 return False 90 91 return True -
trunk/Tools/ChangeLog
r242882 r242884 1 2019-03-13 Aakash Jain <aakash_jain@apple.com> 2 3 [ews-app] Use Buildbot result code variables 4 https://bugs.webkit.org/show_bug.cgi?id=195668 5 6 Reviewed by Alexey Proskuryakov. 7 8 * BuildSlaveSupport/ews-app/ews/common/buildbot.py: 9 (Buildbot): Added Buildbot result code variables. 10 * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: 11 (StatusBubble._build_bubble): Used Buildbot result code variables. 12 1 13 2019-03-13 Thibault Saunier <tsaunier@igalia.com> 2 14
Note: See TracChangeset
for help on using the changeset viewer.