Changeset 242884 in webkit


Ignore:
Timestamp:
Mar 13, 2019 10:03:42 AM (5 years ago)
Author:
aakash_jain@apple.com
Message:

[ews-app] Use Buildbot result code variables
https://bugs.webkit.org/show_bug.cgi?id=195668

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/ews-app/ews/common/buildbot.py:

(Buildbot): Added Buildbot result code variables.

  • BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble): Used Buildbot result code variables.

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py

    r241485 r242884  
    2121# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2222
     23from future.utils import lrange
     24
    2325import logging
    2426import os
     
    3335
    3436class Buildbot():
     37    # Buildbot status codes referenced from https://github.com/buildbot/buildbot/blob/master/master/buildbot/process/results.py
     38    ALL_RESULTS = lrange(7)
     39    SUCCESS, WARNINGS, FAILURE, SKIPPED, EXCEPTION, RETRY, CANCELLED = ALL_RESULTS
     40
    3541    @classmethod
    3642    def send_patch_to_buildbot(cls, patch_path, properties=[]):
  • trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

    r242880 r242884  
    2929from django.views import View
    3030from django.views.decorators.clickjacking import xframe_options_exempt
     31from ews.common.buildbot import Buildbot
    3132from ews.models.patch import Patch
    3233import ews.config as config
     
    5859        if build.result is None:
    5960            bubble["state"] = "started"
    60         elif build.result == 0:  # SUCCESS
     61        elif build.result == Buildbot.SUCCESS:
    6162            bubble["state"] = "pass"
    62         elif build.result == 1:  # WARNINGS
     63        elif build.result == Buildbot.WARNINGS:
    6364            bubble["state"] = "pass"
    64         elif build.result == 2:  # FAILURE
     65        elif build.result == Buildbot.FAILURE:
    6566            bubble["state"] = "fail"
    66         elif build.result == 3:  # SKIPPED
     67        elif build.result == Buildbot.SKIPPED:
    6768            bubble["state"] = "none"
    68         elif build.result == 4:  # EXCEPTION
     69        elif build.result == Buildbot.EXCEPTION:
    6970            bubble["state"] = "error"
    70         elif build.result == 5:  # RETRY
     71        elif build.result == Buildbot.RETRY:
    7172            bubble["state"] = "provisional-fail"
    7273        else:
     
    8687
    8788    def _should_show_bubble_for_build(self, build):
    88         if build and build.result == 3 and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string):
     89        if build and build.result == Buildbot.SKIPPED and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string):
    8990            return False
    9091        return True
  • trunk/Tools/ChangeLog

    r242882 r242884  
     12019-03-13  Aakash Jain  <aakash_jain@apple.com>
     2
     3        [ews-app] Use Buildbot result code variables
     4        https://bugs.webkit.org/show_bug.cgi?id=195668
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
     9        (Buildbot): Added Buildbot result code variables.
     10        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
     11        (StatusBubble._build_bubble): Used Buildbot result code variables.
     12
    1132019-03-13  Thibault Saunier  <tsaunier@igalia.com>
    214
Note: See TracChangeset for help on using the changeset viewer.