Changeset 242962 in webkit

Timestamp:

Mar 14, 2019 1:48:38 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION: Canvas: the first processed action should be selected as soon as it's available if no previous selected action exists
​https://bugs.webkit.org/show_bug.cgi?id=195732
<rdar://problem/48875214>

Reviewed by Matt Baker.

• UserInterface/Views/CanvasSidebarPanel.js:

(WI.CanvasSidebarPanel.prototype._handleRecordingProcessedAction):
Rather than wait until the entire recording is ready, set the selected action as soon as the
first action is ready (assuming there isn't already a selected action).

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CanvasSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-03-14  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION: Canvas: the first processed action should be selected as soon as it's available if no previous selected action exists
+        https://bugs.webkit.org/show_bug.cgi?id=195732
+        <rdar://problem/48875214>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/CanvasSidebarPanel.js:
+        (WI.CanvasSidebarPanel.prototype._handleRecordingProcessedAction):
+        Rather than wait until the entire recording is ready, set the selected action as soon as the
+        first action is ready (assuming there isn't already a selected action).
+
 2019-03-14  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js

@@ -578 +578 @@
         this._createRecordingActionTreeElement(action, index, isInitialStateAction ? this._recordingTreeOutline : this._recordingTreeOutline.children.lastValue);
 
+        if (!this._recording[WI.CanvasSidebarPanel.SelectedActionSymbol]) {
+            console.assert(action === this._recording.actions[0]);
+            this.action = this._recording.actions[0];
+        }
+
         if (this._recording.ready) {
             this._recording.removeEventListener(null, null, this);
-
-            if (!this._recording[WI.CanvasSidebarPanel.SelectedActionSymbol])
-                this.action = this._recording.actions[0];
 
             if (this._recordingProcessingOptionsContainer) {