Changeset 243115 in webkit

Timestamp:

Mar 18, 2019 4:51:42 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[WTF] Remove redundant std::move in StringConcatenate
​https://bugs.webkit.org/show_bug.cgi?id=195798

Patch by Xan Lopez <Xan Lopez> on 2019-03-18
Reviewed by Darin Adler.

Remove redundant calls to WTFMove in return values for this
method. C++ will already do an implicit move here since we are
returning a local value where copy/move elision is not applicable.

• wtf/text/StringConcatenate.h:

(WTF::tryMakeStringFromAdapters):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/text/StringConcatenate.h (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-03-18  Xan Lopez  <xan@igalia.com>
+
+        [WTF] Remove redundant std::move in StringConcatenate
+        https://bugs.webkit.org/show_bug.cgi?id=195798
+
+        Reviewed by Darin Adler.
+
+        Remove redundant calls to WTFMove in return values for this
+        method. C++ will already do an implicit move here since we are
+        returning a local value where copy/move elision is not applicable.
+
+        * wtf/text/StringConcatenate.h:
+        (WTF::tryMakeStringFromAdapters):
+
 2019-03-16  Darin Adler  <darin@apple.com>
 

trunk/Source/WTF/wtf/text/StringConcatenate.h

@@ -279 +279 @@
         makeStringAccumulator(buffer, adapter, adapters...);
 
-        return WTFMove(resultImpl);
+        return resultImpl;
     }
 
@@ -289 +289 @@
     makeStringAccumulator(buffer, adapter, adapters...);
 
-    return WTFMove(resultImpl);
+    return resultImpl;
 }