Changeset 243321 in webkit
- Timestamp:
- Mar 21, 2019 1:39:59 PM (5 years ago)
- Location:
- trunk/Tools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r243320 r243321 1 2019-03-21 Jonathan Bedard <jbedard@apple.com> 2 3 REGRESSSION (r243297): webkitpy tests broken 4 https://bugs.webkit.org/show_bug.cgi?id=196108 5 6 Reviewed by Aakash Jain. 7 8 r243297 updated contributors.json, which broke a few unit tests. 9 10 * Scripts/webkitpy/tool/bot/irc_command_unittest.py: 11 (IRCCommandTest.test_whois): 12 * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py: 13 1 14 2019-03-21 Chris Dumez <cdumez@apple.com> 2 15 -
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py
r206973 r243321 59 59 self.assertEqual('tom: "Vicki Murley" <vicki@apple.com> hasn\'t told me their nick. Boo hoo :-(', 60 60 whois.execute("tom", ["vicki@apple.com"], None, None)) 61 self.assertEqual('tom: I\'m not sure who you mean? "Gavin Barraclough" <barraclough@apple.com> (:gbarra) (r) or "Gavin Peters" <gavinp@chromium.org> (:gavinp) (c)could be \'Gavin\'.',61 self.assertEqual('tom: I\'m not sure who you mean? "Gavin Barraclough" <barraclough@apple.com> (:gbarra) (r) or "Gavin Peters" <gavinp@chromium.org> (:gavinp) could be \'Gavin\'.', 62 62 whois.execute("tom", ["Gavin"], None, None)) 63 63 self.assertEqual('tom: More than 5 contributors match \'david\', could you be more specific?', -
trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations_unittest.py
r170637 r243321 96 96 97 97 def test_basic(self): 98 expected_stdout = " REVIEWER: Xianzhu Wang (wangxianzhu@chromium.org) has 88 reviewed patches\n"98 expected_stdout = "COMMITTER: Xianzhu Wang (wangxianzhu@chromium.org) has 88 reviewed patches\n" 99 99 options = self._make_options() 100 100 suggest_nominations = SuggestNominations() … … 104 104 105 105 def test_with_verbose(self): 106 expected_stdout = " REVIEWER: Xianzhu Wang (wangxianzhu@chromium.org) has 88 reviewed patches\nCONTRIBUTOR: Xianzhu Wang (wangxianzhu@chromium.org) has 88 reviewed patches\n"106 expected_stdout = "COMMITTER: Xianzhu Wang (wangxianzhu@chromium.org) has 88 reviewed patches\nCONTRIBUTOR: Xianzhu Wang (wangxianzhu@chromium.org) has 88 reviewed patches\n" 107 107 options = self._make_options(verbose=True) 108 108 suggest_nominations = SuggestNominations()
Note: See TracChangeset
for help on using the changeset viewer.