Changeset 243490 in webkit

Timestamp:

Mar 26, 2019 3:16:46 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK][WPE] Disable process warming
​https://bugs.webkit.org/show_bug.cgi?id=196208

Patch by Patrick Griffis <Patrick Griffis> on 2019-03-26
Reviewed by Chris Dumez.

Fixes crash caused by r243384.

Process warming is incompatible with our launcher as it expects a valid
WebsiteDataStore at initialization time for sandbox permissions.

• UIProcess/glib/WebProcessPoolGLib.cpp:

(WebKit::WebProcessPool::platformInitialize):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/glib/WebProcessPoolGLib.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-03-26  Patrick Griffis  <pgriffis@igalia.com>
+
+        [GTK][WPE] Disable process warming
+        https://bugs.webkit.org/show_bug.cgi?id=196208
+
+        Reviewed by Chris Dumez.
+
+        Fixes crash caused by r243384.
+
+        Process warming is incompatible with our launcher as it expects a valid
+        WebsiteDataStore at initialization time for sandbox permissions.
+
+        * UIProcess/glib/WebProcessPoolGLib.cpp:
+        (WebKit::WebProcessPool::platformInitialize):
+
 2019-03-25  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp

@@ -87 +87 @@
     if (!memoryPressureMonitorDisabled())
         installMemoryPressureHandler();
+
+    // Process warming is incompatible with the fact our WebProcessProxy::platformGetLaunchOptions()
+    // requires a valid WebsiteDataStore at initialization time for our sandbox permissions.
+    // FIXME: With process warming disabled, the performance of
+    // process-swap-on-navigation is not going to be great. So this needs to be
+    // re-enabled when we enable PSON.
+    configuration().setIsAutomaticProcessWarmingEnabled(false);
 }