Changeset 243499 in webkit


Ignore:
Timestamp:
Mar 26, 2019 9:57:38 AM (5 years ago)
Author:
graouts@webkit.org
Message:

Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
https://bugs.webkit.org/show_bug.cgi?id=196254
<rdar://problem/49124334>

Reviewed by Dean Jackson.

Source/WebCore:

  • page/Quirks.cpp:

(WebCore::Quirks::shouldMousemoveEventHandlingPreventDefault const): Deleted.

  • page/Quirks.h:
  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setMouseEventsSimulationEnabled):
(WebCore::RuntimeEnabledFeatures::mousemoveEventHandlingPreventsDefaultEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMousemoveEventHandlingPreventsDefaultEnabled): Deleted.

Source/WebKit:

  • Shared/WebPreferences.yaml:
Location:
trunk/Source
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r243497 r243499  
     12019-03-26  Antoine Quint  <graouts@apple.com>
     2
     3        Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
     4        https://bugs.webkit.org/show_bug.cgi?id=196254
     5        <rdar://problem/49124334>
     6
     7        Reviewed by Dean Jackson.
     8
     9        * page/Quirks.cpp:
     10        (WebCore::Quirks::shouldMousemoveEventHandlingPreventDefault const): Deleted.
     11        * page/Quirks.h:
     12        * page/RuntimeEnabledFeatures.h:
     13        (WebCore::RuntimeEnabledFeatures::setMouseEventsSimulationEnabled):
     14        (WebCore::RuntimeEnabledFeatures::mousemoveEventHandlingPreventsDefaultEnabled const): Deleted.
     15        (WebCore::RuntimeEnabledFeatures::setMousemoveEventHandlingPreventsDefaultEnabled): Deleted.
     16
    1172019-03-26  Commit Queue  <commit-queue@webkit.org>
    218
  • trunk/Source/WebCore/page/Quirks.cpp

    r243070 r243499  
    201201}
    202202
    203 bool Quirks::shouldMousemoveEventHandlingPreventDefault() const
    204 {
    205     return false;
    206 }
    207 
    208 }
     203}
  • trunk/Source/WebCore/page/Quirks.h

    r243070 r243499  
    4747    bool hasWebSQLSupportQuirk() const;
    4848    bool shouldDispatchSimulateMouseEvents() const;
    49     bool shouldMousemoveEventHandlingPreventDefault() const;
    5049
    5150    WEBCORE_EXPORT bool isTouchBarUpdateSupressedForHiddenContentEditable() const;
  • trunk/Source/WebCore/page/RuntimeEnabledFeatures.h

    r243181 r243499  
    351351    bool mouseEventsSimulationEnabled() const { return m_mouseEventsSimulationEnabled; }
    352352    void setMouseEventsSimulationEnabled(bool isEnabled) { m_mouseEventsSimulationEnabled = isEnabled; }
    353 
    354     bool mousemoveEventHandlingPreventsDefaultEnabled() const { return m_mousemoveEventHandlingPreventsDefaultEnabled; }
    355     void setMousemoveEventHandlingPreventsDefaultEnabled(bool isEnabled) { m_mousemoveEventHandlingPreventsDefaultEnabled = isEnabled; }
    356353#endif
    357354   
     
    537534#if ENABLE(TOUCH_EVENTS)
    538535    bool m_mouseEventsSimulationEnabled { false };
    539     bool m_mousemoveEventHandlingPreventsDefaultEnabled { false };
    540536#endif
    541537
  • trunk/Source/WebKit/ChangeLog

    r243492 r243499  
     12019-03-26  Antoine Quint  <graouts@apple.com>
     2
     3        Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
     4        https://bugs.webkit.org/show_bug.cgi?id=196254
     5        <rdar://problem/49124334>
     6
     7        Reviewed by Dean Jackson.
     8
     9        * Shared/WebPreferences.yaml:
     10
    1112019-03-26  Philippe Normand  <pnormand@igalia.com>
    212
  • trunk/Source/WebKit/Shared/WebPreferences.yaml

    r243347 r243499  
    16121612  condition: ENABLE(TOUCH_EVENTS)
    16131613
    1614 MousemoveEventHandlingPreventsDefaultEnabled:
    1615   type: bool
    1616   defaultValue: false
    1617   humanReadableName: "Prevent default for mousemove events"
    1618   humanReadableDescription: "Allows handling of mousemove events to implicitly call preventDefault() on iOS"
    1619   webcoreBinding: RuntimeEnabledFeatures
    1620   category: internal
    1621   condition: ENABLE(TOUCH_EVENTS)
    1622 
    16231614ReferrerPolicyAttributeEnabled:
    16241615  type: bool
Note: See TracChangeset for help on using the changeset viewer.