Changeset 243707 in webkit


Ignore:
Timestamp:
Apr 1, 2019 12:48:22 PM (5 years ago)
Author:
aakash_jain@apple.com
Message:

[ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
https://bugs.webkit.org/show_bug.cgi?id=196449

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble.get_os_details): Method to get OS and Xcode details.
(StatusBubble._build_bubble): Moved the timestamp logic to common method.
(StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

    r243500 r243707  
    6060        if build.result is None:  # In-progress build
    6161            bubble['state'] = 'started'
    62             bubble['details_message'] = 'Recent messages:\n\n' + self._steps_messages(build) + '\n\n' + self._iso_time(build.step_set.last().started_at)
     62            bubble['details_message'] = 'Recent messages:\n\n' + self._steps_messages(build)
    6363        elif build.result == Buildbot.SUCCESS:
    6464            bubble['state'] = 'pass'
    65             bubble['details_message'] = 'Pass\n\n' + self._iso_time(build.complete_at)
     65            bubble['details_message'] = 'Pass\n\n'
    6666        elif build.result == Buildbot.WARNINGS:
    6767            bubble['state'] = 'pass'
    68             bubble['details_message'] = 'Warning\n\n' + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at)
     68            bubble['details_message'] = 'Warning\n\n' + self._steps_messages(build)
    6969        elif build.result == Buildbot.FAILURE:
    7070            bubble['state'] = 'fail'
    71             bubble['details_message'] = self._most_recent_step_message(build) + '\n\n' + self._iso_time(build.complete_at)
     71            bubble['details_message'] = self._most_recent_step_message(build)
    7272        elif build.result == Buildbot.SKIPPED:
    7373            bubble['state'] = 'none'
     
    8080                bubble['details_message'] += ' Patch was obsolete when EWS attempted to process it.'
    8181            bubble['details_message'] += '\nSome messages were logged while the patch was still eligible:\n\n'
    82             bubble['details_message'] += self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at)
     82            bubble['details_message'] += self._steps_messages(build)
    8383
    8484        elif build.result == Buildbot.EXCEPTION:
    8585            bubble['state'] = 'error'
    86             bubble['details_message'] = ('An unexpected error occured. Recent messages:\n\n'
    87                 + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
     86            bubble['details_message'] = 'An unexpected error occured. Recent messages:\n\n' + self._steps_messages(build)
    8887        elif build.result == Buildbot.RETRY:
    8988            bubble['state'] = 'provisional-fail'
    90             bubble['details_message'] = ('Build is being retried. Recent messages:\n\n'
    91                 + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
     89            bubble['details_message'] = 'Build is being retried. Recent messages:\n\n' + self._steps_messages(build)
    9290        elif build.result == Buildbot.CANCELLED:
    9391            bubble['state'] = 'provisional-fail'
    94             bubble['details_message'] = ('Build was cancelled. Recent messages:\n\n'
    95                 + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
     92            bubble['details_message'] = 'Build was cancelled. Recent messages:\n\n' + self._steps_messages(build)
    9693        else:
    9794            bubble['state'] = 'error'
    98             bubble['details_message'] = ('An unexpected error occured. Recent messages:\n\n'
    99                 + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
     95            bubble['details_message'] = 'An unexpected error occured. Recent messages:\n\n' + self._steps_messages(build)
    10096
    10197        if 'details_message' in bubble:
    10298            bubble['details_message'] = builder_full_name + '\n\n' + bubble['details_message']
     99            os_details = self.get_os_details(build)
     100            timestamp = self.get_build_timestamp(build)
     101            if os_details:
     102                bubble['details_message'] += '\n\n' + os_details + '\n' + timestamp
     103            else:
     104                bubble['details_message'] += '\n\n' + timestamp
    103105
    104106        return bubble
     107
     108    def get_os_details(self, build):
     109        for step in build.step_set.all():
     110            if step.state_string.startswith('OS:'):
     111                return step.state_string
     112        return ''
     113
     114    def get_build_timestamp(self, build):
     115        if not build.complete_at:  # In-progress build
     116            return self._iso_time(build.step_set.last().started_at)
     117        return self._iso_time(build.complete_at)
    105118
    106119    def _iso_time(self, time):
  • trunk/Tools/ChangeLog

    r243706 r243707  
     12019-04-01  Aakash Jain  <aakash_jain@apple.com>
     2
     3        [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
     4        https://bugs.webkit.org/show_bug.cgi?id=196449
     5
     6        Reviewed by Lucas Forschler.
     7
     8        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
     9        (StatusBubble.get_os_details): Method to get OS and Xcode details.
     10        (StatusBubble._build_bubble): Moved the timestamp logic to common method.
     11        (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
     12
    1132019-04-01  Aakash Jain  <aakash_jain@apple.com>
    214
Note: See TracChangeset for help on using the changeset viewer.