Changeset 243854 in webkit

Timestamp:

Apr 3, 2019 8:57:11 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-build] Cancel build and similar operations should have authentication
​https://bugs.webkit.org/show_bug.cgi?id=196520

Reviewed by Dewei Zhu.

• BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from

environment variables.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/master.cfg (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/master.cfg

@@ -1 +1 @@
 import os
 import socket
+import sys
+
+from buildbot.plugins import util
 
 import loadConfig
@@ -16 +19 @@
     'Workers.showWorkerBuilders': True,
 }
+
+if not is_test_mode_enabled:
+    admin_username = os.getenv('EWS_ADMIN_USERNAME')
+    admin_password = os.getenv('EWS_ADMIN_PASSWORD')
+    if not admin_username or not admin_password:
+        print('Environment variables for admin username/password not found. Please ensure these variables are set.')
+        sys.exit(1)
+    # See https://docs.buildbot.net/current/manual/configuration/www.html#example-configs
+    authz = util.Authz(
+        allowRules=[util.AnyControlEndpointMatcher(role="admin")],
+        roleMatchers=[util.RolesFromEmails(admin=[admin_username])]
+    )
+    auth = util.UserPasswordAuth({admin_username: admin_password})
+    c['www']['auth'] = auth
+    c['www']['authz'] = authz
 
 c['protocols'] = {'pb': {'port': 17000}}

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-03  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Cancel build and similar operations should have authentication
+        https://bugs.webkit.org/show_bug.cgi?id=196520
+
+        Reviewed by Dewei Zhu.
+
+        * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
+        environment variables.
+
 2019-04-03  Aakash Jain  <aakash_jain@apple.com>