Changeset 243860 in webkit


Ignore:
Timestamp:
Apr 3, 2019 10:48:20 PM (5 years ago)
Author:
Carlos Garcia Campos
Message:

[ATK] Don't touch accessibility tree in WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=193914

Reviewed by Michael Catanzaro.

Move it to dispatchDidFinishDocumentLoad, since we know we have the document at that point and we can create the
root accessibility object wrapper.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r243855 r243860  
     12019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [ATK] Don't touch accessibility tree in WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld
     4        https://bugs.webkit.org/show_bug.cgi?id=193914
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        Move it to dispatchDidFinishDocumentLoad, since we know we have the document at that point and we can create the
     9        root accessibility object wrapper.
     10
     11        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
     12        (WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
     13        (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
     14
    1152019-04-03  Simon Fraser  <simon.fraser@apple.com>
    216
  • trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

    r243453 r243860  
    600600    // Notify the UIProcess.
    601601    webPage->send(Messages::WebPageProxy::DidFinishDocumentLoadForFrame(m_frame->frameID(), navigationID, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get())));
     602
     603#if HAVE(ACCESSIBILITY) && PLATFORM(GTK)
     604    // Ensure the accessibility hierarchy is updated.
     605    webPage->updateAccessibilityTree();
     606#endif
    602607}
    603608
     
    17091714    webPage->injectedBundleLoaderClient().didClearWindowObjectForFrame(*webPage, *m_frame, world);
    17101715
    1711 
    17121716    WebAutomationSessionProxy* automationSessionProxy = WebProcess::singleton().automationSessionProxy();
    17131717    if (automationSessionProxy && world.isNormal())
    17141718        automationSessionProxy->didClearWindowObjectForFrame(*m_frame);
    1715 
    1716 #if HAVE(ACCESSIBILITY) && PLATFORM(GTK)
    1717     // Ensure the accessibility hierarchy is updated.
    1718     webPage->updateAccessibilityTree();
    1719 #endif
    17201719}
    17211720
Note: See TracChangeset for help on using the changeset viewer.