Changeset 244000 in webkit

Timestamp:

Apr 8, 2019 5:32:57 AM (5 years ago)

Author:

guijemont@igalia.com

Message:

Enable DFG on MIPS
​https://bugs.webkit.org/show_bug.cgi?id=196689

Reviewed by Žan Doberšek.

Since the bytecode change, we enabled the baseline JIT on mips in
r240432, but DFG is still missing. With this change, all tests are
passing on a ci20 board.

Source/JavaScriptCore:

• jit/RegisterSet.cpp:

(JSC::RegisterSet::calleeSaveRegisters):
Added s0, which is used in llint.

Source/WTF:

• wtf/Platform.h: Enable DFG on MIPS by default.

Tools:

• Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.

Location:

trunk

Files:

• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/jit/RegisterSet.cpp (modified) (1 diff)
• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/Platform.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/run-jsc-stress-tests (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-04-08  Guillaume Emont  <guijemont@igalia.com>
+
+        Enable DFG on MIPS
+        https://bugs.webkit.org/show_bug.cgi?id=196689
+
+        Reviewed by Žan Doberšek.
+
+        Since the bytecode change, we enabled the baseline JIT on mips in
+        r240432, but DFG is still missing. With this change, all tests are
+        passing on a ci20 board.
+
+        * jit/RegisterSet.cpp:
+        (JSC::RegisterSet::calleeSaveRegisters):
+        Added s0, which is used in llint.
+
 2019-04-08  Xan Lopez  <xan@igalia.com>
 

trunk/Source/JavaScriptCore/jit/RegisterSet.cpp

@@ -155 +155 @@
         result.set(reg);
 #elif CPU(MIPS)
+    result.set(MIPSRegisters::s0);
 #else
     UNREACHABLE_FOR_PLATFORM();

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-04-08  Guillaume Emont  <guijemont@igalia.com>
+
+        Enable DFG on MIPS
+        https://bugs.webkit.org/show_bug.cgi?id=196689
+
+        Reviewed by Žan Doberšek.
+
+        Since the bytecode change, we enabled the baseline JIT on mips in
+        r240432, but DFG is still missing. With this change, all tests are
+        passing on a ci20 board.
+
+        * wtf/Platform.h: Enable DFG on MIPS by default.
+
 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WTF/wtf/Platform.h

@@ -764 +764 @@
 
 #if USE(JSVALUE32_64)
-#if CPU(ARM_THUMB2) && OS(LINUX)
-/* On ARMv7/Linux the JIT is enabled unless explicitly disabled. */
+#if (CPU(ARM_THUMB2) || CPU(MIPS)) && OS(LINUX)
+/* On ARMv7 and MIPS on Linux the JIT is enabled unless explicitly disabled. */
 #if !defined(ENABLE_JIT)
 #define ENABLE_JIT 1
 #endif
-#elif CPU(MIPS) && OS(LINUX)
-/* Same on MIPS/Linux, but DFG is disabled for now. */
-#if !defined(ENABLE_JIT)
-#define ENABLE_JIT 1
-#endif
-#undef ENABLE_DFG_JIT
-#define ENABLE_DFG_JIT 0
 #else
 /* Disable JIT and force C_LOOP on all other 32bit architectures. */

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-08  Guillaume Emont  <guijemont@igalia.com>
+
+        Enable DFG on MIPS
+        https://bugs.webkit.org/show_bug.cgi?id=196689
+
+        Reviewed by Žan Doberšek.
+
+        Since the bytecode change, we enabled the baseline JIT on mips in
+        r240432, but DFG is still missing. With this change, all tests are
+        passing on a ci20 board.
+
+        * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
+
 2019-04-08  Philippe Normand  <pnormand@igalia.com>
 

trunk/Tools/Scripts/run-jsc-stress-tests

@@ -450 +450 @@
 $isFTLPlatform = !($architecture == "x86" || $architecture == "arm" || $architecture == "mips" || $hostOS == "windows")
 
-if ["mips", "x86"].include?($architecture)
-    # The JIT is temporarily disabled on these platforms since
+if $architecture == "x86"
+    # The JIT is temporarily disabled on this platform since
     # https://trac.webkit.org/changeset/237547
     $jitTests = false