Changeset 24401 in webkit

Timestamp:

Jul 17, 2007 11:27:57 PM (17 years ago)

Author:

weinig

Message:

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=13618
Don't set link targets to "_blank" on middle-click; rely on the policy
delegate to do the right thing.

• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLAnchorElement.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-07-17  Peter Kasting  <zerodpx@gmail.com>
+
+        Reviewed by Hyatt.
+
+        http://bugs.webkit.org/show_bug.cgi?id=13618
+        Don't set link targets to "_blank" on middle-click; rely on the policy
+        delegate to do the right thing.
+
+        * html/HTMLAnchorElement.cpp:
+        (WebCore::HTMLAnchorElement::defaultEventHandler):
+
 2007-07-17  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/html/HTMLAnchorElement.cpp

@@ -186 +186 @@
         String url = parseURL(getAttribute(hrefAttr));
 
-        String target = getAttribute(targetAttr);
-        if (e && e->button() == MiddleButton)
-            target = "_blank";
-
         ASSERT(evt->target());
         ASSERT(evt->target()->toNode());
@@ -214 +210 @@
 
         if (!evt->defaultPrevented() && document()->frame())
-            document()->frame()->loader()->urlSelected(document()->completeURL(url), target, evt, false, true);
+            document()->frame()->loader()->urlSelected(document()->completeURL(url), getAttribute(targetAttr), evt, false, true);
 
         evt->setDefaultHandled();