Changeset 244111 in webkit


Ignore:
Timestamp:
Apr 10, 2019 6:46:01 AM (5 years ago)
Author:
Philippe Normand
Message:

there is no vp8 support in youtube.com/html5 page with libwebkit2gtk 2.24 (MSE enabled)
​https://bugs.webkit.org/show_bug.cgi?id=196615

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Add vp8.0 and vp9.0 in supported mime-types if the corresponding video decoders are found.

No new tests, existing web-platform-tests cover this change.

  • platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:

(WebCore::GStreamerRegistryScanner::initialize):

LayoutTests:

Update WPE baselines and add/unskip the
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType.html test in GTK.

  • platform/gtk/TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Copied from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt.
  • platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt:
Location:
trunk
Files:
3 added
5 edited
1 copied

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r244107 r244111  
     12019-04-10  Philippe Normand  <pnormand@igalia.com>
     2
     3        there is no vp8 support in youtube.com/html5 page with libwebkit2gtk 2.24 (MSE enabled)
     4        https://bugs.webkit.org/show_bug.cgi?id=196615
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        Update WPE baselines and add/unskip the
     9        imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType.html test in GTK.
     10
     11        * platform/gtk/TestExpectations:
     12        * platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Copied from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt.
     13        * platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt:
     14
    1152019-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
    216

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r244107 r244111  
    31223122webkit.org/b/148935 accessibility/scroll-to-make-visible-with-subfocus.html [ Failure ]
    31233123
    3124 webkit.org/b/148936 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType.html [ Failure ]
    3125 
    31263124webkit.org/b/149128 fast/text/control-characters [ ImageOnlyFailure ]
    31273125

  • trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt

    r244110 r244111  
    5353PASS video/webm; codecs="vorbis" (optional)
    5454PASS video/webm; codecs="vp8" (optional)
    55 FAIL video/webm; codecs="vp8.0" (optional) assert_equals: video/webm; codecs="vp8.0" expected "probably" but got ""
     55PASS video/webm; codecs="vp8.0" (optional)
    5656PASS video/webm; codecs="vp9" (optional)
    57 FAIL video/webm; codecs="vp9.0" (optional) assert_equals: video/webm; codecs="vp9.0" expected "probably" but got ""
     57PASS video/webm; codecs="vp9.0" (optional)
    5858PASS video/webm codecs subset
    5959PASS video/webm codecs order

  • trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt

    r242037 r244111  
    5353PASS video/webm; codecs="vorbis" (optional)
    5454PASS video/webm; codecs="vp8" (optional)
    55 FAIL video/webm; codecs="vp8.0" (optional) assert_equals: video/webm; codecs="vp8.0" expected "probably" but got ""
     55PASS video/webm; codecs="vp8.0" (optional)
    5656PASS video/webm; codecs="vp9" (optional)
    57 FAIL video/webm; codecs="vp9.0" (optional) assert_equals: video/webm; codecs="vp9.0" expected "probably" but got ""
     57PASS video/webm; codecs="vp9.0" (optional)
    5858PASS video/webm codecs subset
    5959PASS video/webm codecs order

  • trunk/Source/WebCore/ChangeLog

    r244109 r244111  
     12019-04-10  Philippe Normand  <pnormand@igalia.com>
     2
     3        there is no vp8 support in youtube.com/html5 page with libwebkit2gtk 2.24 (MSE enabled)
     4        https://bugs.webkit.org/show_bug.cgi?id=196615
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        Add vp8.0 and vp9.0 in supported mime-types if the corresponding video decoders are found.
     9
     10        No new tests, existing web-platform-tests cover this change.
     11
     12        * platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
     13        (WebCore::GStreamerRegistryScanner::initialize):
     14
    1152019-04-10  Philippe Normand  <pnormand@igalia.com>
    216

  • trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp

    r241585 r244111  
    169169            m_codecMap.add(AtomicString("vp8"), vp8DecoderAvailable.isUsingHardware);
    170170            m_codecMap.add(AtomicString("x-vp8"), vp8DecoderAvailable.isUsingHardware);
     171            m_codecMap.add(AtomicString("vp8.0"), vp8DecoderAvailable.isUsingHardware);
    171172        }
    172173        if (vp9DecoderAvailable) {
    173174            m_codecMap.add(AtomicString("vp9"), vp9DecoderAvailable.isUsingHardware);
    174175            m_codecMap.add(AtomicString("x-vp9"), vp9DecoderAvailable.isUsingHardware);
     176            m_codecMap.add(AtomicString("vp9.0"), vp9DecoderAvailable.isUsingHardware);
    175177        }
    176178        if (opusSupported)
Note: See TracChangeset for help on using the changeset viewer.