Changeset 244150 in webkit

Timestamp:

Apr 10, 2019 2:16:42 PM (5 years ago)

Author:

youenn@apple.com

Message:

Layout Test http/wpt/fetch/response-opaque-clone.html is sometimes timing out on iOS simulator
​https://bugs.webkit.org/show_bug.cgi?id=194525
<rdar://problem/48012229>

Reviewed by Alex Christensen.

Test is no longer flaky on MacOS.
As per flakiness dashboard, it sometimes times out on iOS simulator.
It sometimes passes after running for 20 seconds.
Mark it as Slow and improve the test to output more sub-tests.
Removed unnecessary removal of cache since test runner will clear them at the end of the test.

• http/wpt/fetch/response-opaque-clone-expected.txt:
• http/wpt/fetch/response-opaque-clone.html:
• platform/ios-simulator-wk2/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/wpt/fetch/response-opaque-clone-expected.txt (modified) (1 diff)
• http/wpt/fetch/response-opaque-clone.html (modified) (2 diffs)
• platform/ios-simulator-wk2/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-04-10  Youenn Fablet  <youenn@apple.com>
+
+        Layout Test http/wpt/fetch/response-opaque-clone.html is sometimes timing out on iOS simulator
+        https://bugs.webkit.org/show_bug.cgi?id=194525
+        <rdar://problem/48012229>
+
+        Reviewed by Alex Christensen.
+
+        Test is no longer flaky on MacOS.
+        As per flakiness dashboard, it sometimes times out on iOS simulator.
+        It sometimes passes after running for 20 seconds.
+        Mark it as Slow and improve the test to output more sub-tests.
+        Removed unnecessary removal of cache since test runner will clear them at the end of the test.
+
+        * http/wpt/fetch/response-opaque-clone-expected.txt:
+        * http/wpt/fetch/response-opaque-clone.html:
+        * platform/ios-simulator-wk2/TestExpectations:
+
 2019-04-10  Justin Fan  <justin_fan@apple.com>
 

trunk/LayoutTests/http/wpt/fetch/response-opaque-clone-expected.txt

@@ -1 +1 @@
 
 PASS Check opaque response can be cloned and cached correctly 
+PASS fetched response 
+PASS cloned response 
+PASS cached response 
 

trunk/LayoutTests/http/wpt/fetch/response-opaque-clone.html

@@ -12 +12 @@
     <script>
 
-function testResponseOpacity(response, test, testName)
+function testResponseOpacity(response, testName)
 {
-    assert_equals(response.type, "opaque", testName + " type");
-    assert_equals(response.status, 0, testName + " status");
-    assert_equals(response.statusText, "", testName + " statusText");
-    assert_equals(response.url, "", testName + " url");
-    assert_false(response.redirected, testName + " redirected");
-    assert_true(response.headers.values().next().done, testName + " headers");
-    assert_equals(response.body, null, testName + " opaque response body should be null");
+    test(() => {
+        assert_equals(response.type, "opaque", testName + " type");
+        assert_equals(response.status, 0, testName + " status");
+        assert_equals(response.statusText, "", testName + " statusText");
+        assert_equals(response.url, "", testName + " url");
+        assert_false(response.redirected, testName + " redirected");
+        assert_true(response.headers.values().next().done, testName + " headers");
+        assert_equals(response.body, null, testName + " opaque response body should be null");
+    }, testName);
 }
-promise_test(async function(test) {
+
+promise_test(async function() {
     var request = new Request(get_host_info().HTTP_REMOTE_ORIGIN, { mode: "no-cors" });
     var response = await fetch(request);
 
-    testResponseOpacity(response, test, "fetched response");
+    testResponseOpacity(response, "fetched response");
 
     var clone = response.clone();
 
-    testResponseOpacity(clone, test, "cloned response");
+    testResponseOpacity(clone, "cloned response");
     var buffer = await clone.arrayBuffer();
     assert_equals(buffer.byteLength, 0, "cloned opaque response buffer should be null");
 
     // WK1 does not support Cache API yet.
-    if (!self.caches)
+    if (!self.caches) {
+        test(() => {
+        }, "cached response");
         return;
+    }
 
     var cache = await self.caches.open("test");
@@ -42 +48 @@
     var cached = await cache.match(request.url);
 
-    testResponseOpacity(cached, test,  "cached response")
+    testResponseOpacity(cached, "cached response")
     buffer = await cached.arrayBuffer();
     assert_equals(buffer.byteLength, 0, "cached opaque response buffer should be null");
 
-    await self.caches.delete("test");
 }, "Check opaque response can be cloned and cached correctly");
     </script>

trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations

@@ -79 +79 @@
 
 webkit.org/b/196358 http/wpt/cache-storage/quota-third-party.https.html [ Pass Failure ]
+http/wpt/fetch/response-opaque-clone.html [ Slow ]
 
 webkit.org/b/196376 [ Debug ] storage/domstorage/localstorage/private-browsing-affects-storage.html [ Pass Failure ]