Changeset 244186 in webkit
- Timestamp:
- Apr 10, 2019 11:48:20 PM (5 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r244184 r244186 1 2019-04-10 Chris Dumez <cdumez@apple.com> 2 3 Regression(r244144) ProcessSwap.ReuseSuspendedProcessLoadHTMLString API test is flaky 4 https://bugs.webkit.org/show_bug.cgi?id=196784 5 6 Reviewed by Antti Koivisto. 7 8 When we enter accelerated compositing mode in the new process, we supposed to *close* the last 9 SuspendedPageProxy, not destroy it. This was causing flakiness in the test because it was testing 10 that we were using the SuspendedPageProxy's process for a cross-site link navigation, which is 11 an optimization. This optimization was partly broken by r244144 as the SuspendedPageProxy would 12 not sometimes be gone by the time we need it. 13 14 * UIProcess/SuspendedPageProxy.cpp: 15 (WebKit::SuspendedPageProxy::pageEnteredAcceleratedCompositingMode): 16 1 17 2019-04-10 Alex Christensen <achristensen@webkit.org> 2 18 -
trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp
r244144 r244186 170 170 if (m_suspensionState == SuspensionState::FailedToSuspend) { 171 171 // We needed the failed suspended page to stay alive to avoid flashing. Now we can get rid of it. 172 m_process->processPool().removeSuspendedPage(*this); // Will destroy |this|.172 close(); 173 173 } 174 174 }
Note: See TracChangeset
for help on using the changeset viewer.