Changeset 244199 in webkit

Timestamp:

Apr 11, 2019 3:56:40 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION(r244195): Timelines: unable to take heap snapshot
​https://bugs.webkit.org/show_bug.cgi?id=196832
<rdar://problem/49828862>

Reviewed by Simon Fraser.

• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype.heapSnapshotAdded):
(WI.TimelineManager.prototype._addRecord):
Heap snapshots can be taken outside of a timeline recording, so remove the early return (and
assertion) that checks for an active recording before adding the heap snapshot record.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/TimelineManager.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-04-11  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(r244195): Timelines: unable to take heap snapshot
+        https://bugs.webkit.org/show_bug.cgi?id=196832
+        <rdar://problem/49828862>
+
+        Reviewed by Simon Fraser.
+
+        * UserInterface/Controllers/TimelineManager.js:
+        (WI.TimelineManager.prototype.heapSnapshotAdded):
+        (WI.TimelineManager.prototype._addRecord):
+        Heap snapshots can be taken outside of a timeline recording, so remove the early return (and
+        assertion) that checks for an active recording before adding the heap snapshot record.
+
 2019-04-11  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js

@@ -583 +583 @@
         // Called from WI.HeapAllocationsInstrument.
 
-        console.assert(this.isCapturing());
-        if (!this.isCapturing())
-            return;
-
         this._addRecord(new WI.HeapAllocationsTimelineRecord(timestamp, snapshot));
     }
@@ -861 +857 @@
     _addRecord(record)
     {
-        console.assert(this.isCapturing());
-
         this._activeRecording.addRecord(record);