Changeset 244253 in webkit


Ignore:
Timestamp:
Apr 15, 2019 12:11:11 AM (5 years ago)
Author:
graouts@webkit.org
Message:

Ensure iOS layout traits are used for media controls in modern compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=196812
<rdar://problem/47460637>

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode.html

Instead of looking at the UA string, check whether we support touches which is the correct indicator of whether we should
be using the iOS layout traits for media controls.

  • Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype.get layoutTraits):

LayoutTests:

Add a new test that enforces modern compatibility mode and checks that the iOS controls are used.

  • media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode-expected.txt: Added.
  • media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r244250 r244253  
     12019-04-11  Antoine Quint  <graouts@apple.com>
     2
     3        Ensure iOS layout traits are used for media controls in modern compatibility mode
     4        https://bugs.webkit.org/show_bug.cgi?id=196812
     5        <rdar://problem/47460637>
     6
     7        Reviewed by Dean Jackson.
     8
     9        Add a new test that enforces modern compatibility mode and checks that the iOS controls are used.
     10
     11        * media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode-expected.txt: Added.
     12        * media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode.html: Added.
     13
    1142019-04-14  Fujii Hironori  <Hironori.Fujii@sony.com>
    215
  • trunk/Source/WebCore/ChangeLog

    r244248 r244253  
     12019-04-11  Antoine Quint  <graouts@apple.com>
     2
     3        Ensure iOS layout traits are used for media controls in modern compatibility mode
     4        https://bugs.webkit.org/show_bug.cgi?id=196812
     5        <rdar://problem/47460637>
     6
     7        Reviewed by Dean Jackson.
     8
     9        Test: media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode.html
     10
     11        Instead of looking at the UA string, check whether we support touches which is the correct indicator of whether we should
     12        be using the iOS layout traits for media controls.
     13
     14        * Modules/modern-media-controls/media/media-controller.js:
     15        (MediaController.prototype.get layoutTraits):
     16
    1172019-04-14  Rob Buis  <rbuis@igalia.com>
    218
  • trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js

    r241492 r244253  
    100100            return LayoutTraits.Compact;
    101101
    102         let traits = window.navigator.platform === "MacIntel" ? LayoutTraits.macOS : LayoutTraits.iOS;
     102        let traits = GestureRecognizer.SupportsTouches ? LayoutTraits.iOS : LayoutTraits.macOS;
    103103        if (this.isFullscreen)
    104104            return traits | LayoutTraits.Fullscreen;
Note: See TracChangeset for help on using the changeset viewer.