Changeset 244270 in webkit

Timestamp:

Apr 15, 2019 10:29:26 AM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Uncaught Exception: Can't find variable: WebGL2RenderingContext
​https://bugs.webkit.org/show_bug.cgi?id=196874
<rdar://problem/49858912>

Reviewed by Timothy Hatcher.

• UserInterface/Models/Recording.js:

(WI.Recording.prototype.createContext):

• UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.process.getContent):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/Recording.js (modified) (1 diff)
• UserInterface/Models/RecordingAction.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-04-15  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Uncaught Exception: Can't find variable: WebGL2RenderingContext
+        https://bugs.webkit.org/show_bug.cgi?id=196874
+        <rdar://problem/49858912>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Models/Recording.js:
+        (WI.Recording.prototype.createContext):
+
+        * UserInterface/Models/RecordingAction.js:
+        (WI.RecordingAction.prototype.process.getContent):
+
 2019-04-15  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/Recording.js

@@ -452 +452 @@
             return createCanvasContext("2d");
 
-        if (this._type === WI.Recording.Type.BitmapRenderer)
+        if (this._type === WI.Recording.Type.CanvasBitmapRenderer)
             return createCanvasContext("bitmaprenderer");
 

trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js

@@ -212 +212 @@
                 return context.getImageData(0, 0, context.canvas.width, context.canvas.height).data;
 
-            if (context instanceof WebGLRenderingContext || context instanceof WebGL2RenderingContext) {
+            if (context instanceof WebGLRenderingContext || (window.WebGL2RenderingContext && context instanceof WebGL2RenderingContext)) {
                 let pixels = new Uint8Array(context.drawingBufferWidth * context.drawingBufferHeight * 4);
                 context.readPixels(0, 0, context.canvas.width, context.canvas.height, context.RGBA, context.UNSIGNED_BYTE, pixels);