Changeset 244274 in webkit


Ignore:
Timestamp:
Apr 15, 2019 11:34:51 AM (5 years ago)
Author:
Devin Rousso
Message:

Web Inspector: Debugger: deleting a special breakpoint should disable it
https://bugs.webkit.org/show_bug.cgi?id=196737
<rdar://problem/49740680>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype.ondelete):

Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r244271 r244274  
     12019-04-15  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: Debugger: deleting a special breakpoint should disable it
     4        https://bugs.webkit.org/show_bug.cgi?id=196737
     5        <rdar://problem/49740680>
     6
     7        Reviewed by Timothy Hatcher.
     8
     9        * UserInterface/Views/BreakpointTreeElement.js:
     10        (WI.BreakpointTreeElement.prototype.ondelete):
     11
    1122019-04-15  Devin Rousso  <drousso@apple.com>
    213
  • trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js

    r242118 r244274  
    7878    ondelete()
    7979    {
    80         if (!WI.debuggerManager.isBreakpointRemovable(this._breakpoint))
     80        if (!WI.debuggerManager.isBreakpointRemovable(this._breakpoint)) {
     81            if (this._breakpoint.disabled)
     82                InspectorFrontendHost.beep();
     83            else
     84                this._breakpoint.disabled = true;
    8185            return true;
     86        }
    8287
    8388        // We set this flag so that TreeOutlines that will remove this
Note: See TracChangeset for help on using the changeset viewer.