Changeset 244283 in webkit

Timestamp:

Apr 15, 2019 1:12:39 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-build] Do not run clean build by default on EWS builders
​https://bugs.webkit.org/show_bug.cgi?id=196897

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-build/steps.py:

(ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing
untracked directories like WebKitBuild).
(CheckOutSource.init): Pass method=clean so that Buildbot clean the working directory. This does not remove
untracked files/directories (like WebKitBuild).

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -94 +94 @@
                                                 timeout=2 * 60 * 60,
                                                 alwaysUseLatest=True,
+                                                method='clean',
                                                 progress=True,
                                                 **kwargs)
@@ -134 +135 @@
 
         d = self.downloadFileContentToWorker('.buildbot-diff', patch)
-        d.addCallback(lambda _: self.downloadFileContentToWorker('.buildbot-patched', 'patched\n'))
         d.addCallback(lambda res: shell.ShellCommand.start(self))
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-15  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Do not run clean build by default on EWS builders
+        https://bugs.webkit.org/show_bug.cgi?id=196897
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
+        file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
+        untracked directories like WebKitBuild).
+        (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
+        untracked files/directories (like WebKitBuild).
+
 2019-04-15  Per Arne Vollan  <pvollan@apple.com>