Changeset 244319 in webkit

Timestamp:

Apr 15, 2019 6:43:30 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Stop using hyphenationFactor
​https://bugs.webkit.org/show_bug.cgi?id=196949
<rdar://problem/49779594>

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-04-15
Reviewed by Geoffrey Garen.

• UIProcess/Cocoa/WKSafeBrowsingWarning.mm:

(-[WKSafeBrowsingTextView initWithAttributedString:forWarning:]):
I added this use of hyphenationFactor in r241124 but the other changes in that revision make the use of hyphenationFactor redundant.
There is a reason to remove it in the radar.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/WKSafeBrowsingWarning.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-04-15  Alex Christensen  <achristensen@webkit.org>
+
+        Stop using hyphenationFactor
+        https://bugs.webkit.org/show_bug.cgi?id=196949
+        <rdar://problem/49779594>
+
+        Reviewed by Geoffrey Garen.
+
+        * UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
+        (-[WKSafeBrowsingTextView initWithAttributedString:forWarning:]):
+        I added this use of hyphenationFactor in r241124 but the other changes in that revision make the use of hyphenationFactor redundant.
+        There is a reason to remove it in the radar.
+
 2019-04-15  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm

@@ -563 +563 @@
     self.scrollEnabled = NO;
 #endif
-#if PLATFORM(WATCHOS)
-    self.layoutManager.hyphenationFactor = 1;
-#endif
 
     return self;